Repository navigation
[FIX] Stop the HUD animating after the shape retracts - #132
Merged
Merged
Conversation
Talkify idled at about 20% CPU once a session had run, and stayed there for as long as the app was open. Measured on a nine-day-old process: 21.8% instantaneous against 0.0% for a fresh launch that had not dictated yet. WindowServer was compositing every one of those frames. Two causes, one behind the other. The retract cleared the draft but not the shaping caption, and the caption is what decides whether the label is mounted. The label then animated, because its TimelineView was the only one here without a paused condition, so it ran ShapingSheen.metal at the display's rate with the panel ordered out. The retract now clears the caption, and the timeline pauses with the reveal the way every other visual pauses with its session. After the fix, a session then idle: 0.2%. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01J1TQSE6pcRXYRYbk3xEYxQ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Talkify idled at about 20% CPU once a session had run, and stayed there for as long as the app was open. This was found while investigating a MacBook whose battery had started dying in half its usual time. Measured on a nine-day-old process: 21.8% instantaneous, against 0.0% for a fresh launch that had not dictated yet. WindowServer sat at 44% compositing the frames.
Two causes, one behind the other. The retract cleared the draft and the volatile text but not the shaping caption, and the caption is what decides whether the shaping label is mounted, so the label outlived the shape. The label then animated for as long as it was mounted, because its TimelineView was the only one in the project without a paused condition: it kept running ShapingSheen.metal at the display's refresh rate with the panel ordered out.
The retract now clears the caption alongside the draft, and the timeline pauses with the reveal, the way every other visual here pauses when its session is not live. After the fix, a session followed by idle measures 0.2%.
The test waits on the condition rather than on the clock. The first version slept for the retract plus a margin, passed on its own and failed under the parallel suite, which is the flake #82 and #116 were about.