Repository navigation
[FIX] Stop anything restoring the listening placeholder after speech ends - #125
Merged
Merged
Conversation
showShaping cleared the placeholder, but a clear only beats the writers that ran before it. showModelDownload(nil) asks for the placeholder again, and its guard is machine.isSessionActive, which is state != .idle and so includes finishing. A model download completing during the shaping phase put Listening (latched) back under the caption. The rule now lives where the placeholder is decided rather than in one writer: it is a listening affordance, so it is empty once the session stops listening, whoever asks. Reset when the next session opens. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012Abfbei4sXuCngAWEH8Z2k
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
showShaping cleared the placeholder, but a clear only beats the writers that ran before it. showModelDownload(nil) asks for the placeholder again, and its guard is machine.isSessionActive, which is state != .idle and therefore includes finishing. A speech model download completing during the shaping phase put Listening (latched) back on screen under the shaping caption.
The rule now lives where the placeholder is decided rather than inside one writer. It is a listening affordance, so it is empty once the session stops listening, whoever asks for it, and it comes back when the next session opens. Two tests cover both halves.
Worth saying plainly: this is a real hole and it reproduces in a test, but I could not confirm it is the cause of the screenshot that started this. That path needs a model download finishing in the shaping window. Three other theories I tried did not hold up, so the cause may still be elsewhere.