Skip to content

Record retained packet delivery and session closeout #735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
topij merged 1 commit into from
Sep 11, 2026
Merged

Record retained packet delivery and session closeout #735

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions docs/kit-friction-log.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,25 @@

## 2026-09-11

- **Case-insensitive report paths overwrote a completed review report.** During
PR #733's final adversarial review on 2026-09-11, the reviewer wrote `REPORT.md`
while the launcher used `codex exec -o report.md` in the same scratch directory.
Those names aliased on the filesystem, so the launcher's final-summary write
replaced the full report. **L** — the complete reviewer-authored text remained
in a completed command in `events.jsonl`; shell-token and Python-AST literal
parsing recovered it without executing the command. The
[complete receipt](https://github.com/topij/agentic-dev-kit/pull/733#issuecomment-5639699233)
preserves that recovery before merge. Proposed remedy: give the reviewer report
and launcher summary distinct basenames and check their destination identities
before launching. This was session review orchestration, not an established kit
engine defect. `gh search issues --repo topij/agentic-dev-kit` with queries
`"case-insensitive" "report"` and `"REPORT.md"`, including PRs, at
`fc46efa0570f866f19cccf11834f909d5f37cf69` on 2026-09-11 in
`/Users/topi/Coding/agentic-dev-kit` returned no match for the combined query and
PR matches for the filename query; no collision issue was identified by
that bounded search. Parked because the operator excludes tracker payloads from
this work. No tracker write or friction sweep is authorized by this entry.

- **The review runtime stopped before delivering required adversarial coverage.**
PR #733's [receipt at `88c5b044d5a42e33d2c4b0158be0957b4014678a`](https://github.com/topij/agentic-dev-kit/pull/733#issuecomment-5633065607)
and [receipt at `207683b073f4d34cf22c5d9e1635f1c23239b6d4`](https://github.com/topij/agentic-dev-kit/pull/733#issuecomment-5633204702)
Expand Down
12 changes: 9 additions & 3 deletions docs/kit-handoff.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
> Older session blocks graduate to [`kit-handoff-history.md`](kit-handoff-history.md) once
> this file crosses its line budget (`scripts/check_doc_budget.py`).

Last updated: 2026-09-11 — source repair delivered; revised retained-update decision prepared.
Last updated: 2026-09-11 — source repair and revised retained-update packet delivered.
Phase 5 delivery item 5 remains incomplete; item 6's replay remains complete.

## Latest session — 2026-09-11 (ITEM5-B revised retained-update packet, in Codex)
Expand All @@ -33,8 +33,14 @@ read-only audit and forge records retain post-acceptance checkpoint comparisons.
The packet retains complete review receipts before its audit-ordering correction,
with earlier UPDATE-03 questions/evidence preserved and the current `-r5` binding
explicit. The packet records unresolved generic-upgrade bootstrap findings outside
its proposed execution; no further source repair or approved deferral is claimed. PR #733 owns packet review/delivery. UPDATE-01 is consumed; UPDATE-02 and its old
questions, payloads, ledgers and incomplete review receipts remain preserved.
its proposed execution; no further source repair or approved deferral is claimed.
[PR #733](https://github.com/topij/agentic-dev-kit/pull/733) merged on 2026-09-11 as
`e6b8e182466046a820198fa28c8cc52dc06509d0`, from reviewed head
`fc46efa0570f866f19cccf11834f909d5f37cf69`. Its
[completion checkpoint](https://github.com/topij/agentic-dev-kit/pull/733#issuecomment-5639767232)
retains review, verification, merge readback and the pending exact approval question.
UPDATE-01 is consumed; UPDATE-02 and its old questions, payloads, ledgers and
incomplete review receipts remain preserved.

No retained update is approved. Ownership acceptance does not establish custom
wrap-up functionality, client verification or field exit. The accepted inherited
Expand Down
4 changes: 4 additions & 0 deletions saved_plans/codex-parity-plan_2026-08-23.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -456,6 +456,10 @@ historical observation it was and is not silently refreshed.
delivered by #734 at `7e0232ed871b37a315c5509c97b83d3b00b1a3fd`. The
[UPDATE-03 packet](phase5-item5-b-update03-decision_2026-09-11.md) proposes the
revised exact local retained update after fresh read-only checkpoint checks.
Kit #733 delivered that packet on 2026-09-11 as
`e6b8e182466046a820198fa28c8cc52dc06509d0`; its
[completion checkpoint](https://github.com/topij/agentic-dev-kit/pull/733#issuecomment-5639767232)
preserves the review/merge evidence and unanswered exact approval question.
Its current `-r5` binding retains the audit and dependent-command isolation correction,
corrects copied provenance, and preserves unresolved generic-upgrade source findings
outside the proposed execution;
Expand Down
Loading