Skip to content

is_install_baseline must reject non-object manifest JSON #723

Description

@topij

At kit source e698ec4, scripts/tests/conftest.py uses membership directly on json.loads output. The replay probe imported the corresponding cs-toolkit helper at 21fe33bb040e7fdcc8f7d3d7c4402e768b1ff351 on 2026-09-09: null and numeric JSON raised TypeError; a matching string or list returned True. Require a dict before testing kit_commit, and cover these forms in the helper tests. The approved adopter installation has no test-module callers of this helper. Finding: https://github.com/in-parallel-oy/cs-toolkit/pull/2255#discussion_r3971657369. Preserve the replay’s pinned source and record this accepted limitation; implementation remains separate.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P3Priority 3 — backlogbugSomething isn't workingtestTest coverage

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions