fix: repair broken code fence and em dash in CONTRIBUTING - #210
Merged
Merged
Conversation
The co-author example used fence markers containing a literal n character instead of a newline, so GitHub treated the trailer as a language identifier and never closed the block. That example is the line contributors are most likely to copy verbatim. Line 18 also carried the byte sequence 47 C3 87 C3 B6 where an em dash belongs, reading 'Keep PRs focused GCo one logical change per PR'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two rendering defects in
CONTRIBUTING.md:1. Broken code fence in the "Pair programming" section. The fence markers
contained a literal
ncharacter where a newline belonged:GitHub reads
nCo-authored-by:...as the fence's language identifier and neversees a valid closing fence, so the co-author example does not render as a code
block. This is the one line a contributor is most likely to copy verbatim.
2. Mojibake in the pull request rules. Line 18 contained the byte sequence
47 C3 87 C3 B6(GÇö) where an em dash belongs, so it read"Keep PRs focused GÇö one logical change per PR".
Type of change
Verification
```nsequences remaining47 C3 87 C3 B6remainingE2 80 94npm test— all tests passingChecklist
npm testpasses locallylib/*.test.mjsfor behavior changesBadge output
None. Badge generation is unchanged.