Conversation
What was broken The Support API allowed a Support Team member to close a ticket without being assigned, and its ticket responses omitted the persisted closer ID. Root cause Closure authorization checked only the Support Team role, and close and unassign decisions were not serialized on the ticket row. What was changed Require assignment to the acting support user, lock close and unassign decisions against races, and expose the stored closer ID in ticket responses. Any added/updated tests Added coverage for unassigned rejection before writes, shared ticket locking, closer persistence and mapping, and preserved close idempotency and notification behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
The Support API allowed a Support Team member to close a ticket without being assigned, and its ticket responses omitted the persisted closer ID.
Root cause
Closure authorization checked only the Support Team role, and close and unassign decisions were not serialized on the ticket row.
What was changed
Require assignment to the acting support user, lock close and unassign decisions against races, and expose the stored closer ID in ticket responses.
Any added/updated tests
Added coverage for unassigned rejection before writes, shared ticket locking, closer persistence and mapping, and preserved close idempotency and notification behavior.
Validation