Fix Resource API filters for Opportunities - #28
Merged
Conversation
jmgasper
marked this pull request as ready for review
August 13, 2026 06:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
roleId,memberId, and resolvedmemberHandlefilters with the caller-authorized resource set403Opportunities UI contract
Use
GET /v6/resourceswith the existing query names:challengeId, canonical SubmitterroleId,page, andperPagememberIdThe response body remains the legacy resource array. Pagination remains in
X-Page,X-Per-Page,X-Total,X-Total-Pages, navigation headers, andLink.Security behavior
The API determines visibility first, then ANDs every requested exact filter into that candidate set. Filters cannot expand visibility. Ordinary human callers may request only their own member ID or handle; requests for another member remain forbidden.
Validation
pnpm lintpnpm buildpnpm test:logger: 2 passingpnpm test:adapter: 5 passinggit diff --checkThe complete legacy
pnpm testsuite was also attempted with all three local PostgreSQL databases provisioned. Its pre-existing setup path fails before Resource query fixtures are created becauseapp-bootstrap.tsreplaces native Promise with Bluebird while the currenttc-core-library-jsevent client callsPromise.withResolvers; that setup failure cascades across the legacy database suite. The focused query/controller tests avoid event mutations and pass against deterministic PostgreSQL fixtures.