Conversation
What was broken Date-only endDate values were interpreted at midnight, excluding records later on the selected end date and making same-day ranges appear empty. Root cause Timestamp filters used an inclusive <= comparison against a date value cast to midnight. What was changed Use half-open date ranges ending at the start of the following calendar day for payment accrual, SFDC payments, and SFDC BA fee queries. Clarify full-day end-date semantics in API docs. Any added/updated tests Added SQL regression assertions for all four affected query variants, covering next-day exclusive upper bounds and removal of the old midnight cutoff.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
Selecting an end date excluded records created later on that date. A same-day range generally returned no records.
Root cause
The report queries cast date-only endDate values to timestamps at midnight and used that instant as the inclusive upper bound.
What was changed
Any added/updated tests
pnpm lintandpnpm buildpass under Node 22.13.1.pnpm test --runInBandrun reports 348 passing and 21 failing tests. The same 21 failures were reproduced on a cleanorigin/developworktree and are unrelated to this change: 19 SFDC DTO empty-value expectations, one TaaS empty-array expectation, and one Talent Manager report-directory expectation.