Conversation
What was broken Links rendered from a support ticket Description navigated the current Support tab instead of opening a new tab. Root cause The shared Support Markdown renderer used ReactMarkdown's default anchor output, which does not set a new-tab target. What was changed Added a scoped Markdown anchor renderer that preserves the link destination while applying target="_blank" and rel="noopener noreferrer". Updated the renderer documentation to describe the behavior. Any added/updated tests Added regression coverage for the bare GFM challenge URL shown in the ticket recording, including href, target, and rel assertions. All 9 Support test suites, lint, and the production build pass. The repository-wide suite still has unrelated failures reproduced on clean origin/dev.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
Links rendered from a support ticket Description navigated the current Support tab instead of opening a new tab.
Root cause
The shared Support Markdown renderer used ReactMarkdown's default anchor output, which does not set a new-tab target.
What was changed
Added a scoped Markdown anchor renderer that preserves each destination while applying
target="_blank"andrel="noopener noreferrer". The renderer documentation now describes the new-tab behavior.Any added/updated tests
Added a regression test for the bare GFM challenge URL shown in the ticket recording. It verifies the rendered link's
href,target, andrelattributes.Validation completed:
origin/dev.