Conversation
What was broken Support staff and ticket raiser replies displayed only their handles, making their roles difficult to distinguish. Root cause The ticket conversation rendered reply handles without using the existing author and ticket-owner IDs to identify support-authored responses. What was changed Append (Support Team) to replies authored by someone other than the ticket owner. Ticket-owner replies remain unchanged, including when the owner also holds the Support Team role. Any added/updated tests Added TicketDetailPage coverage that verifies the suffix appears for support replies and not for ticket-owner replies.
Resolve the TicketDetailPage test conflict while preserving both reply-role labelling and the newer assignment/closure coverage. Fix stale deferred-screener fixture references exposed by the merged dev build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
Support staff and ticket raiser replies displayed only their handles, making their roles difficult to distinguish.
Root cause
The ticket conversation rendered reply handles without using the existing author and ticket-owner IDs to identify support-authored responses.
What was changed
Replies authored by someone other than the ticket owner now display
{handle} (Support Team). Ticket-owner replies remain unchanged, including when the owner also holds the Support Team role.Any added/updated tests
Added TicketDetailPage coverage for both ticket-owner and support-authored replies.
Validation passed:
The complete monorepo test command was also run. It reported 222 passing suites and 18 failing suites in unchanged Work, Engagements, Wallet, and Customer Portal code due existing alias, mock, and expectation issues; the Support suites all passed.