Conversation
What was broken Review showed only the newest submission per member when a Design challenge allowed more than one. Work Manager could also reset the visible submission-limit selection after saving a draft when the save response omitted that metadata entry. Root cause Review reduced every finite limit to the API's single isLatest flag and grouped history without using the configured count or exact submission type. The draft editor trusted sparse save-response metadata when resetting the form. What was changed Resolve the same latest-X Design policy used by the backend, rank complete member/type history before phase eligibility, and display every eligible Screening and Review row within that window. Preserve unlimited Design behavior and Development's latest-one behavior. Retain the submitted submissionLimit value when a successful draft response omits that entry. Any added/updated tests Added and updated regression coverage for finite counts, unlimited and malformed metadata, independent contest/checkpoint histories, rank-before-eligibility, Review row forwarding, Screening selection, and Work Manager draft-save metadata preservation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
The earlier PM-5758 fixes restored submission-limit configuration, guarded member uploads, enforced the limit atomically, and created Screening and Review scorecards for the latest configured number of Design submissions. QA still saw only the newest submission per member in Review, and Work Manager could stop displaying a saved limit immediately after saving a draft.
QA also repeated the checkpoint-versus-final submission failure in community-app. Investigation confirmed the merged follow-up already handles those submission types independently, but a later deployment from the older
payload-cmsbranch overwrote the corrected dev bundle.Root cause
The Review UI treated every finite limit as a boolean latest-only policy and relied on the API's
isLatestflag, which identifies exactly one submission. It also grouped history without the configured count or exact submission type. Work Manager reset its form from a save response that can omit thesubmissionLimitmetadata entry.What was changed
isLatest.submissionLimitin Work Manager when a successful draft response omits that specific entry, while respecting a value returned by the API.Deployment follow-up: redeploy current community-app
developand update/rebasepayload-cmsbefore it deploys again so the already-merged type-scoped guards from PR #7262 remain live.Any added/updated tests
Added and updated coverage for finite counts of one and multiple submissions, unlimited and malformed metadata, backend-policy edge cases, independent contest/checkpoint histories, rank-before-eligibility, Screening selection, Review row forwarding, and Work Manager draft-save metadata preservation.
Validation:
origin/dev, and all PM-5758 tests pass.