Conversation
What was broken Late July 31 SFDC payments could render as August 1 when the report was viewed from a browser in a positive-offset timezone. Root cause The payment table formatted timestamps in the browser's local timezone even though SFDC payment reports use America/New_York calendar dates. What was changed Render SFDC payment timestamps explicitly in America/New_York while preserving the existing browser-local formatting for billing-account profile dates. Any added/updated tests Added a Reports page regression using the reported July 31 boundary in Asia/Colombo. The test also confirms billing-account profile dates keep their existing formatting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
Late July 31 SFDC payments could render as August 1 for users whose browser timezone is ahead of America/New_York.
Root cause
The payment table formatted SFDC timestamps in the browser's local timezone even though the report and Salesforce integration use America/New_York calendar dates.
What was changed
Render only SFDC payment-table timestamps explicitly in America/New_York. Billing-account profile dates retain their existing browser-local formatting.
Any added/updated tests