Conversation
What was broken The previous PM-5787 changes allowed the standard Screener assignment to be deferred, but an empty Checkpoint Screener assignment still blocked draft saves and launches. Root cause The shared optional-assignment helper matched only the exact Screening phase name and explicitly excluded Checkpoint Screening. What was changed Extended the optional member-assignment policy to both Screening and Checkpoint Screening while keeping their reviewer configurations and scorecards required. Updated the Challenge Editor documentation to describe both deferred roles. Any added/updated tests Updated schema, required-field, save, launch, resource-allocation, and hydration coverage for an unassigned Checkpoint Screener. The four focused suites pass with 124 tests; lint and the production build pass. The full repository run matches the clean dev baseline with 222 passing suites and 18 unrelated failing suites.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
The first PM-5787 fix made the standard Screener assignment optional and taught Autopilot to wait for screeners. The second fix preserved later Review assignments when Screening was empty. QA then confirmed that Checkpoint Screener was still required, so two-round Design challenges could not be saved or launched without assigning that role up front.
Root cause
The shared UI helper that controls schema validation, save and launch validation, and member-field required state matched only the exact
Screeningphase name. Its implementation and tests explicitly excludedCheckpoint Screening.What was changed
ScreeningandCheckpoint Screeningas deferrable.Any added/updated tests
yarn lint,yarn run build, andgit diff --checkpass. The build retains existing repository warnings.origin/devcontrol run produced the exact same counts and failures, confirming that baseline is unrelated to PM-5787.