Skip to content

PM-5848: Refresh support ticket details after read #2130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmgasper merged 2 commits into from
Aug 14, 2026
Merged

PM-5848: Refresh support ticket details after read #2130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe01311
PM-5848: Refresh support ticket details after read
jmgasper Aug 12, 2026
cffa992
Merge dev into PM-5848
jmgasper Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 4 additions & 29 deletions src/apps/support/src/pages/ticket-details/TicketDetailPage.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ describe('TicketDetailPage reply access', () => {
.toBeTruthy()
})

it('preserves freshly revalidated assignees when marking a ticket read completes', async () => {
it('revalidates fresh detail after marking the ticket read', async () => {
const markReadRequest = createDeferred<void>()
mockedMarkRead.mockReturnValue(markReadRequest.promise)
mockUseSWR.mockReturnValue({
Expand All @@ -254,35 +254,10 @@ describe('TicketDetailPage reply access', () => {

await waitFor(() => {
expect(mockMutate)
.toHaveBeenCalledWith(expect.any(Function), false)
.toHaveBeenCalledTimes(1)
})

const updateCachedTicket = mockMutate.mock.calls[0][0] as (
ticket?: SupportTicketDetail,
) => SupportTicketDetail | undefined
const freshlyRevalidatedTicket: SupportTicketDetail = {
...closedTicket,
assignees: [{
assignedAt: '2026-08-07T01:30:00.000Z',
handle: 'support-staff',
userId: '67890',
}],
hasUnread: true,
responseCount: 1,
responses: [{
createdAt: '2026-08-07T01:30:00.000Z',
id: 'response-1',
markdown: 'We are investigating.',
readBy: [],
userHandle: 'support-staff',
userId: '67890',
}],
}

expect(updateCachedTicket(freshlyRevalidatedTicket))
.toEqual({ ...freshlyRevalidatedTicket, hasUnread: false })
expect(updateCachedTicket(undefined))
.toBeUndefined()
expect(mockMutate.mock.calls[0])
.toEqual([])
})

it('identifies support team replies without labelling the ticket owner', () => {
Expand Down
4 changes: 1 addition & 3 deletions src/apps/support/src/pages/ticket-details/TicketDetailPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,9 +75,7 @@ export const TicketDetailPage: FC = () => {

markedReadTicket.current = data.id
markSupportTicketRead(data.id)
.then(() => mutate(current => (current
? { ...current, hasUnread: false }
: current), false))
.then(() => mutate())
.catch(() => undefined)
}, [data, mutate])

Expand Down
Loading