Skip to content

Prod - August 2026 Release 2 - #2124

Merged
jmgasper merged 50 commits into
masterfrom
dev
Aug 12, 2026
Merged

Prod - August 2026 Release 2#2124
jmgasper merged 50 commits into
masterfrom
dev

Conversation

vas3a and others added 30 commits August 6, 2026 13:22
PM-5126 Add member handle input box in bulk reports lookup
PM-5126 Fix bulk member lookup for TMs
What was broken

The challenge header stayed at 0% while completed Checkpoint Review, Checkpoint Screening, or Screening work was visible in the active phase.

Root cause

The header progress calculation always consumed final Review rows, so phase-specific screening and checkpoint review assignments never contributed to the percentage.

What was changed

Made review progress select the rows for the current or open review-like phase, including an open-phase fallback when the challenge has no current phase label.

Counted COMPLETED and SUBMITTED screening-style assignments, including individual assignments within multi-screener rows, while preserving existing final Review filtering.

Any added/updated tests

Added unit coverage for completed Checkpoint Review, partial Checkpoint Screening, open-phase fallback, and multi-screener Screening progress.

All 177 Review app tests pass. The full monorepo suite was also run and retains unrelated failures outside the Review app.
What was broken
Work Manager did not expose the submission-limit setting for design challenges and normalized every existing value to Unlimited, preventing managers from configuring or preserving a limited count.

Root cause
The compatibility field had been changed to render no controls and always rewrite submissionLimit metadata to the unlimited payload.

What was changed
Restored the setting as mutually exclusive Unlimited and Limited radio options, with a numeric count field for Limited. The editor now safely restores existing limits, defaults missing or malformed metadata to Unlimited, and persists the established JSON metadata contract without disrupting initial resource hydration.

Any added/updated tests
Updated MaximumSubmissionsField tests to cover the default, existing limits, count changes, switching to Unlimited, malformed metadata, and deferred dirty-state normalization. Updated the challenge editor documentation.
What was broken

Design challenges could not be saved as drafts or launched unless a Screener member was assigned to the standard Screening phase up front.

Root cause

Closed-opportunity reviewer validation and required input state treated Screening like every other human review phase.

What was changed

Kept the Screening phase configuration and scorecard required while allowing its member slots to remain empty, including for legacy phase instance IDs. Other review phases and Checkpoint Screening remain unchanged.

Any added/updated tests

Added schema, form save and launch, and reviewer UI coverage for optional standard Screening assignment and retained required behavior.
What was broken
Design challenge reviewers could select a Submission Place rating from 1 through 10 without any explanation that higher ratings represent better placements.

Root cause
The Submission Place question used the same generic scale selector as every other scorecard question, so the UI did not communicate the placement mapping.

What was changed
Added the 10-to-3 placement mapping and the 2-and-1 no-placement guidance below the Answer selector. The guidance is limited to Design-track SCALE questions named Submission Place.

Any added/updated tests
Added focused component coverage for the Design Submission Place case and negative coverage for non-Design challenges and unrelated scorecard questions.
What was broken

New work-app challenges enabled winning-submission downloads for all registrants, including Development challenges that should restrict access to passing submitters.

Root cause

The new-challenge creation payload hard-coded the download-access metadata to true instead of deriving it from the selected challenge track.

What was changed

Defaulted Development challenges to passing-submitter access while preserving all-registrant access for Design and other tracks. Reused normalized Development-track detection and updated the existing field documentation.

Any added/updated tests

Added creation-payload regression cases verifying Design persists true and Development persists false.
What was broken

On desktop profiles with reviewer and copilot roles, the Copilot pill began 40px to the left of the Member Stats card.

Root cause (if identifiable)

The role pills use an equal grid with a 16px gap, while TCO and Member Stats use an asymmetric flex row with a 32px gap. The independent layouts produced different second-column offsets.

What was changed

Inset only the second role card by 40px when both the desktop and two-column container thresholds are met, preserving its right edge and leaving single-role and stacked layouts unchanged.

Any added/updated tests

Added a stylesheet regression assertion for the guarded desktop second-card alignment. All 80 Profiles tests, lint, and the production build pass. The full repository suite was also run; 18 unrelated suites fail in areas untouched by this ticket.
PM-5827: Align Copilot pill with member stats
PM-5825: set track-specific submission download defaults
PM-5789: Add submission placement rating guidelines
PM-5787: Allow deferred screener assignment
PM-5758: restore design submission limit settings
PM-5772: Track progress for the current review phase
himaniraghav3 and others added 20 commits August 10, 2026 10:41
What was broken

Leaving the Screening member empty allowed a saved Review member to appear as the Screener after reload, while the Review assignment became blank.

Root cause

Persisted reviewer resources are allocated back to phase rows by role. The allocator processed each row through its generic Reviewer fallback immediately, so the earlier Screening row consumed the Reviewer resource before the actual Review row. A legacy generic role id on Screening could cause the same misallocation.

What was changed

Allocate phase-specific and other primary role pools across every reviewer row before using generic fallbacks. Treat an explicit generic Reviewer role on a specialized phase as a fallback too, while preserving sequential fallback allocation for legacy challenges.

Any added/updated tests

Added allocator coverage for an empty Screening assignment with a persisted generic role id and an assigned Review member. Added editable reviewer hydration coverage confirming Screening stays empty and Review keeps its member. The 28 focused tests pass; lint and the production build pass. The full repository run remains at its documented baseline of 220 passing suites and 18 unrelated failing suites.
PM-5787: Preserve reviewer assignments without screener
PM-5460 Add preferred roles to profile completeness
@jmgasper
jmgasper requested a review from kkartunov as a code owner August 12, 2026 02:55
@jmgasper
jmgasper merged commit ffac25c into master Aug 12, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants