Conversation
What was broken The My Submissions tab replaced a completed Marathon Match provisional score with a dash while system tests were still running. Root cause The row hid the provisional score for every in-progress test status without distinguishing an in-progress provisional run from a later system run. What was changed The My Submissions row now keeps the completed provisional score visible when the current test process is system, matching the existing public submissions behavior. Any added/updated tests Added focused My Submissions row tests covering both an in-progress system run and an in-progress provisional run.
What was broken The My Submissions badge showed the full attempt count on its own tab, then dropped to the latest-only count after visiting the Submissions tab. Root cause Both tabs replace the same Marathon Match submissions state. The badge read the loaded attempts array length, even though the latest-only response carries the member's total submissionCount separately. What was changed Derive a dedicated My Submissions count from submissionCount with a loaded-attempt fallback, pass it through the challenge header, and use it for desktop and mobile badges. Any added/updated tests Added regression coverage for deriving the total from a latest-only response and rendering that total independently of the loaded attempts array.
PM-5803: Show provisional score during system tests
PM-5780: Keep My Submissions count stable
What was broken Community challenge details treated serialized submission-limit metadata as a number, so configured limits displayed as Unlimited. Members could also attempt another submission after reaching a configured limit without the requested guidance. Root cause The sidebar expected a legacy scalar metadata value, while current challenges store a JSON string. Submission entry points did not read that metadata or verify the member's existing submissions. What was changed Added safe parsing for current and legacy submission-limit metadata, displayed the configured count in the challenge sidebar, and guarded both the challenge submit action and the final submission boundary. Members at the limit now see the requested Submission Limit Reached message and must delete an existing submission before replacing it. Any added/updated tests Added parser and message tests, header action coverage, and submission-boundary tests for unlimited, below-limit, reached-limit, and lookup-failure cases.
What was broken The community app submissions tab displayed a placeholder final score of 0 while Marathon Match system tests were still in progress. Root cause The public submission row treated every finite final score as displayable when final results were enabled. In-progress system summations include a placeholder score and status metadata, but final score rendering did not consult the status. What was changed The row now displays N/A for final scores while that submission's system test is active. Completed zero scores remain visible. Any added/updated tests Added focused row tests verifying an in-progress system test renders N/A and a successful system test preserves a zero score. The focused tests, full test suite, lint, and production build pass.
PM-5826: Show N/A during system tests
PM-5758: honor design challenge submission limits
What was broken Downloading a submission from My Submissions failed after Review API began returning a signed storage redirect. Root cause Community App fetched the redirecting endpoint as a blob, so Firefox followed the authenticated request to S3 and triggered a rejected CORS preflight. What was changed Request the browser-safe /download-url endpoint with the member token, validate the signed URL, and start the existing browser-managed download directly from that URL. Any added/updated tests Added service coverage for the authenticated, URL-encoded download-url request, signed URL parsing, and missing URL rejection.
PM-5831: Fix My Submissions download redirect
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://topcoder.atlassian.net/browse/PM-5831
https://topcoder.atlassian.net/browse/PM-5803
https://topcoder.atlassian.net/browse/PM-5780
https://topcoder.atlassian.net/browse/PM-5826