Conversation
What was broken Downloading a submission from My Submissions failed after Review API began returning a signed storage redirect. Root cause Community App fetched the redirecting endpoint as a blob, so Firefox followed the authenticated request to S3 and triggered a rejected CORS preflight. What was changed Request the browser-safe /download-url endpoint with the member token, validate the signed URL, and start the existing browser-managed download directly from that URL. Any added/updated tests Added service coverage for the authenticated, URL-encoded download-url request, signed URL parsing, and missing URL rejection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
Downloading a submission from the My Submissions page failed after Review API began returning a signed storage redirect.
Root cause
Community App fetched the redirecting download endpoint as a blob. Firefox followed that authenticated request to S3, which triggered a rejected CORS preflight instead of downloading the file.
What was changed
/submissions/{submissionId}/download-urlendpoint with the member token.Any added/updated tests
download-urlrequest.