Conversation
What was broken The community app submissions tab displayed a placeholder final score of 0 while Marathon Match system tests were still in progress. Root cause The public submission row treated every finite final score as displayable when final results were enabled. In-progress system summations include a placeholder score and status metadata, but final score rendering did not consult the status. What was changed The row now displays N/A for final scores while that submission's system test is active. Completed zero scores remain visible. Any added/updated tests Added focused row tests verifying an in-progress system test renders N/A and a successful system test preserves a zero score. The focused tests, full test suite, lint, and production build pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
The community app submissions tab displayed a placeholder final score of 0 while Marathon Match
system tests were still in progress. The expected value during that state is N/A.
Root cause
The public submission row treated every finite final score as displayable when final results were
enabled. In-progress system summations include a placeholder score and status metadata, but final
score rendering did not consult the status.
What was changed
The row now checks the submission's existing system-test progress metadata and displays N/A while
the test status is active. Completed zero scores remain visible.
Any added/updated tests
Added focused submission-row coverage verifying:
Validation completed successfully:
npm run jest -- __tests__/shared/components/challenge-detail/Submissions/SubmissionRow/index.jsxnpm test(151 suites and 328 tests passed; 5 suites and 23 tests skipped)npm run lintnpm run build