Conversation
What was broken The Community app's My Submissions table left Current Tests Process, Test Status, and Test Progress blank for Marathon Match submissions. Root cause Community merged metadata-free rows from /reviewSummations before metadata-bearing nested rows from /submissions. Duplicate summation IDs used first-wins deduplication, discarding the safe test progress metadata. What was changed Updated review summation deduplication to merge object metadata from later duplicate rows while retaining submitter enrichment from the original row. Any added/updated tests Added a regression test that combines metadata-free top-level and metadata-bearing nested copies of the same summation and verifies a single merged row retains submitter data and all three test progress fields.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
The Community app's My Submissions table left Current Tests Process, Test Status, and Test Progress blank for Marathon Match submissions.
Root cause
Community merged metadata-free rows from
/reviewSummationsbefore metadata-bearing nested rows from/submissions. Duplicate summation IDs used first-wins deduplication, discarding the safe test progress metadata.What was changed
Updated review summation deduplication to merge object metadata from later duplicate rows while retaining submitter enrichment from the original row.
Any added/updated tests
Added a regression test that combines metadata-free top-level and metadata-bearing nested copies of the same summation and verifies a single merged row retains submitter data and all three test progress fields.