All issues

[business-logic] verify_windows' 13-line no-op configureVerifyCommand relies on Go's default Kill (TerminateProcess kills only the direct child), so grandchildren of a timed-out verify command survive holding the stdout pipe - unix uses SETPGID group-kill; the file also has zero CI compile coverage (no GOOS=windows in Makefile or workflows)

#1526

· topcheer opened

on Sep 3, 2026

[code-review] vendorToCatwalk maps zai and minimax to two byte-identical model-list sources with no dedup in populateDefaultModels, so the default vendor's onboarding model panel shows every GLM (and MiniMax) model twice; budget.go's tool_result branch counts only Output text - embedded Images cost 0 tokens in analysis while the provider side actually uploads (and bills) them as image blocks

#1525

· topcheer opened

on Sep 3, 2026

[business-logic] #1440-A's bgorphan terminal-status exit is dead code: it matches uppercase 'SUCCESS'/'FAILED'/'CRASHED'/'REMOVED' but the real CommandJobStatus values are lowercase 'completed'/'failed'/'cancelled'/'timed_out' (CRASHED/REMOVED don't exist at all) - completed jobs keep cycling false 'may have errored, hung' warnings until the 3-injection budget burns out, after which genuinely orphaned hung jobs stay silent forever (charter inverted); the test feeds a fictional 'Status: SUCCESS' sample so it only ever validated the dead branch

#1524

· topcheer opened

on Sep 3, 2026

[code-review] VendorPresets iterates the endpoints map unordered, so the onboarding wizard's default endpoint (and the desktop DefaultEndpoint flag) is random per launch; mcp_patch's switch omits 'ws' and skips case-normalization (dead code today - active patch path unaffected); npm detection overwrites go.mod-decided commands violating the profile's own priority contract; 'TAGS' substring match injects -tags goolm for DOCKER_TAGS etc.; knight's per-field fallback splices cross-vendor endpoint ids

#1523

· topcheer opened

on Sep 3, 2026

[business-logic] the '# activity-label' prefix that run_command prompts mandate blinds three sibling detectors at once: isVerificationCommand / coverageIsVerifyCommand / eaIsVerifyTool all tokenize '#' as the first token, so verification debt never zeroes (false warnings), verify_coverage_gap is completely dead on conforming agents, and edit_abandon inherits the same blindness - stripLeadingShellComment exists but only 2 call sites got the #471/#950 fix; exit-127 isNonFailureExit swallows real go-test failures inside '||' chains as 'tool not available' green

#1522

· topcheer opened

on Sep 3, 2026

[business-logic] #1438-A is half-done: bare 'latest' survives next to a comment saying 'the bare forms are dropped' (better WAS narrowed - the asymmetry proves the omission), making the three new phrase shapes dead entries shadowed by the bare match + category dedup; #1438-B repeats the same mistake in CJK: bare 排序/大概/最新的/最近的 substrings with an ASCII-only isWordByte that makes boundary checks always-true for Chinese

#1521

· topcheer opened

on Sep 3, 2026

[business-logic] batch_replace double-escapes the read-before-edit guard: it's absent from the agent.go gate (dead extractor branch) while the same loop recordCreated's the modified EXISTING files, exempting follow-up edits from both unread and stale-read checks; goto/label forward jumps are flagged unreachable (no CFG); the classic two-line unsafe.Pointer round-trip slips both patterns the header claims to out-do vet on; unused-param advice says 'removing' first - destructive for interface-impl signatures

#1520

· topcheer opened

on Sep 3, 2026

[code-review] keys.env is os.Setenv'd wholesale into the process env so every bash command (run_command passes os.Environ()) and MCP server inherits ALL plaintext API keys; workspace a2a.yaml values bypass instanceFields tracking and late-merge after the global snapshot, deep-merging into the GLOBAL config for all workspaces; instance-scope zeroing (max_iterations->0) is permanently lost - diffInt suppresses zero, deep-merge keeps the old value, Save strips the global key; double-quoted env values failing strconv.Unquote keep their quotes as the credential

#1519

· topcheer opened

on Sep 3, 2026

[business-logic] #1437-A's tail-anchor fallback checkpoint backfires on resume: the anchor is loaded as a summary REPLACEMENT (ContextMessages=[anchor], nothing after it), so a long session that never compacted crashes back with ~1 message instead of the pre-fix 200; undo_blind is dead for its charter scenario (undo_edit has no path arg and isn't in the wildcard trio, so the headline undo_edit->edit_file blind-edit case never warns); batch_replace's whitelist entry is dead (its files[] is a bare string array no extractor reads), and undo_blind's precision inversion (git_reset with explicit paths bypasses the wildcard)

#1518

· topcheer opened

on Sep 3, 2026

[code-review] AddEndpoint documents 'already exists it is updated' but wholesale-replaces the EndpointConfig: setting just base_url via 'config set vendors.X.endpoints.Y' wipes API key, discovered models and SelectedModel (persisted); SetVendorAPIKey (2 production callers incl 'config set vendors.X.api_key') never writes keys.env - the exact onboarding-loop-on-restart bug #1435 fixed for AddVendor/AddEndpoint; RemoveEndpoint/RemoveVendor leave c.Endpoint/c.Vendor dangling so every startup re-triggers onboarding

#1517

· topcheer opened

on Sep 2, 2026

[business-logic] type_switch_check is dead code (absent from write_integrity's registry, tests green via direct calls); #1436-A's errorRecoverySignals covers 3 of 9 edit tools so failed write_file retries get no effort bump; hedging HIGH/MEDIUM regex overlap double-counts a single sentence to threshold

#1516

· topcheer opened

on Sep 2, 2026

[code-review] the .ggcode/a2a.yaml override never expands ${VAR} references while the main config, vendors.yaml and im.yaml all do - writing api_key: ${A2A_KEY} there merges the literal string over the real value and auth fails silently; onboarding with the A2A checkbox replaces the whole cfg.A2A struct with a zero-value (wiping host/port/auth on re-run) instead of just clearing Disabled; anthropic_bootstrap's fallback ignores ANTHROPIC_BASE_URL entirely and matches hosts by 'bigmodel' substring, sending third-party proxy tokens to the built-in official endpoint while silently dropping the user's real URL; and keys.env loading treats an empty-but-set shell env var as precedence, so 'export OPENAI_API_KEY=' placeholders shadow the real persisted key every startup

#1515

· topcheer opened

on Sep 2, 2026