monitr: right window file sorting and UX improvements#454
Open
marcosfrenkel wants to merge 10 commits into
Open
monitr: right window file sorting and UX improvements#454marcosfrenkel wants to merge 10 commits into
marcosfrenkel wants to merge 10 commits into
Conversation
# Conflicts: # plottr/apps/monitr.py
… sorting options for right window
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is a cleaned-up version of the work originally proposed in #429 by @AndreaDuina — thank you for the great ideas! The changes have been reworked to keep the scope focused and avoid introducing lab-specific conventions into the general codebase.
What's included
Right window file sorting
Copy folder path button
Monospace rendering for
.mono.mdfiles.mono.md(e.g.log.mono.md) are rendered in monospace font (Courier New, 10pt). This is useful for files containing tabular or fixed-width text.TextEditWidgetdocstring and surfaced as a tip in the "Add Comment" name dialog.Copy data paths button label
.ddh5data file paths of all currently shown items).What was changed relative to #429
paths.mdconvention for registering alternative paths — this was a lab-specific pattern that would be undiscoverable to other users without broader documentation.CopyPathSectionclass which was defined but never used.copy,importlib,Process,Iterable,all_datadicts_from_hdf5,unwrap_optional).qpu_old.json,qpu_new.json,param_dict.json,directry_path.md) were replaced with a general type-based sort.