Measure tool should wait for section plane selection. - #127
Merged
Merged
Conversation
sallen2
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<MeasureTool>mounted beside a<SectionTool>with no cut yet offers no snap and places no point until a cut is chosen or the section tool is unmounted. Escape clearing the cut puts it back to waiting.SectionStoregainsisPickingandsetPicking, counted likeisEngaged, raised by the section tool's picker.Public package release
pnpm changesetand committed the generated Changeset.no-release-neededlabel and explained why below.Validation
pnpm --filter @toolpath/viewer test,check-types,pnpm lint,pnpm knip, and the example's Playwright suite pass. The new browser test fails against the snapper-hiding change alone and passes with the press guard.