Skip to content

Add more viewer features - #124

Merged
sallen2 merged 16 commits into
mainfrom
nathan/viewer-parity
Sep 29, 2026
Merged

sallen2 merged 16 commits into
mainfrom
nathan/viewer-parity

Conversation

@dementive

@dementive dementive commented Sep 17, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Add configurable stock rendering with fixed dimensions, allowances, wall/floor stock, offsets, camera framing, and semantic wireframe edges. Allows viewer consumers to pass in custom stock geometry if they need to.
  • Add direction-based face highlights, selection-driven X-ray focus, hover cards, and improved picking behavior.
  • Add a section-plane gizmo with bidirectional dragging, physical cut measurement, and direction-coloured handles with theme overrides.
  • Add the bundled banana-for-scale model and a viewer-scoped, composable toolbar with reusable styling.
  • Update the React viewer example and browser coverage for the new controls and interactions.
  • Add different viewer control settings based on the user's preferred CAD program.

Public package release

  • Changesets are included for @toolpath/viewer.
  • No breaking changes.

@dementive
dementive marked this pull request as ready for review September 18, 2026 23:37

@BradEstey BradEstey left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we document the class names and data-* props in the README and make sure every element has a class name; Components like ViewerToolbar.Viewer and HoverCard are missing them.

@BradEstey

Copy link
Copy Markdown
Member

Also remove the "Click end, vertex, end · Shift locks an axis · Del removes last · Esc drops" explanation from measure tool. Merge measure and section view panels together. Hide cut depth label. Remove clear cut text and use trash icon. Add trash icon button to measure. Make distance/angle a toggle.
Screenshot 2026-09-21 at 1 16 47 PM

@BradEstey

Copy link
Copy Markdown
Member

I wonder if toolbar may need to be its own package actually. It would be nice if it used the @toolpath/ui components but I wouldn't want to make @toolpath/ui as dependency of @toolpath/viewer.

@sallen2
sallen2 merged commit aac8fea into main Sep 29, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants