Add more viewer features - #124
Merged
Merged
Conversation
dementive
force-pushed
the
nathan/viewer-parity
branch
from
September 18, 2026 22:07
b5c76a9 to
1110a1f
Compare
dementive
marked this pull request as ready for review
September 18, 2026 23:37
BradEstey
previously requested changes
Sep 21, 2026
BradEstey
left a comment
Member
There was a problem hiding this comment.
Can we document the class names and data-* props in the README and make sure every element has a class name; Components like ViewerToolbar.Viewer and HoverCard are missing them.
Member
Member
|
I wonder if toolbar may need to be its own package actually. It would be nice if it used the |
sallen2
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Public package release
@toolpath/viewer.