You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Good catch, and it's a real defect — but it can't land here, because the code this edits no longer exists on the branch this would merge into.
efaa214 ("Take the packaged Fusion exporter", open as #9) deleted app/shared/fusion-library.ts and its test and moved the export into @toolpath/tool-support/export/fusion, whose per-type rules come from Autodesk's published JSON Schema. app/shared/fusion-input.ts is the whole seam that remains. Merging this to main and then main into paul/tool_catalog is a modify/delete conflict on both files, and the resolution is to take the deletion:
CONFLICT (modify/delete): apps/catalog/app/shared/fusion-library.ts
deleted in HEAD and modified in nathan/fix-holder-export
The bug survived the move, so the finding still stands. fusionHolder's published arm does exactly what holderOf did here — writes holder.gaugeLength against a stack that fromPublished builds out to projection. The measured arm was already right: it cuts at the gage line with belowGageLine and takes the gauge length from the last vertex.
gaugeLength is derived from the exported stack on both arms, so a document can never again state one length while drawing another.
Where the vendor's figure disagrees, a dropped note names both numbers — on a BT 30, REGO-FIX's B4 - B3 is 48.4 mm, the gauge-line-to-flange distance, and that's the whole gap.
assemblyGaugeLength needed nothing: geometry.ts already takes the holder gauge from the fusionHolder result, so it's null when the holder is dropped. That's your second change, already correct upstream.
Both fixtures published projection === gaugeLength, which is why nothing caught this — here and upstream both. #114 adds a case where they differ; four of its five assertions fail against the old behaviour.
Closing this one as superseded. The template-side follow-up (dep bump, fixture, and the 'gauge length' warning test whose meaning changes) lands after #114 releases and #9 merges.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.