build: resolve the Toolpath packages onto one tool-support - #10
Merged
Merged
Conversation
`@toolpath/app-support` 0.1.3 depends on `@toolpath/tool-support` `^0.3.0` and `@toolpath/tool-drawing` 1.0.0 and `@toolpath/tool-scraper` 3.0.0 both depend on `^0.3.1`, while the workspace pinned `tool-support` itself at 0.3.0. A `0.x` caret does not span a minor, so no single version satisfied all four and the install carried two copies — the drawing and the scraper computing a stickout against one `tool-support` while the applications read another. The three are at 0.1.4, 1.0.1 and 3.0.1, each depending on `^0.4.0`, and `tool-support` is 0.4.0 here. `pnpm-lock.yaml` now resolves one copy. `gripsShank`'s tolerance is a thousandth of an inch as of `tool-support` 0.3.1, where it had been a float artifact's last bit, so a 9.5 mm shank is within a 3/8" collet's size. `toolholding.test.ts` pins both sides of that boundary rather than only the float below it. `@toolpath/api` stays at 0.4.1. Reaching 0.6.0 crosses two minors on a `0.x` package and moves datasheet values, which is its own change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The workspace resolved two copies of
@toolpath/tool-support.app-support0.1.3 wants
^0.3.0;tool-drawing1.0.0 andtool-scraper3.0.0 want^0.3.1; the workspace pinnedtool-support0.3.0 directly. A0.xcaret doesnot span a minor, so nothing satisfied all four at once and the drawing and the
scraper computed a stickout against a different
tool-supportthan theapplications read.
app-support0.1.3 → 0.1.4tool-drawing1.0.0 → 1.0.1tool-scraper3.0.0 → 3.0.1tool-support0.3.0 → 0.4.0All three now depend on
^0.4.0, andpnpm-lock.yamlresolves a single copy.Behaviour that moves
gripsShank's tolerance became a thousandth of an inch intool-support0.3.1,up from a float artifact's last bit, because four Kennametal collets were
refusing the shank they are sold for. A shank within a thousandth of a collet's
stated size now matches it — a 9.5 mm shank fits a 3/8" collet.
packages/catalog-data/src/toolholding.test.tspinned only the float case andnow pins both sides of the boundary.
tool-support0.4.0 is additive over 0.3.1: two new entry points,exportandexport/fusion. Nothing existing changed shape.Not in this PR
@toolpath/apistays at 0.4.1 against 0.6.0 published. That is two minors on a0.xpackage and moves computed datasheet values, so it wants its own changeand its own testing.
Validation
pnpm checkpasses — style, lint, build, types, and 291 tests across sixpackages.
pnpm-lock.yamlcarries one@toolpath/tool-supportentry, and everyapp and sibling resolves to
tool-support@0.4.0.