Repository navigation
fix: paid delegation briefs name spend scope and cap - #270
Merged
Merged
Conversation
3 tasks
Contributor
Author
|
Independent review of 96f3fc0 (relayed from reviewer, codex/gpt-6.1-sol, read-only diff review): No findings in exact head 96f3fc0.
Repository tests were not run by the reviewer; the reported 514-test result remains independently unverified by them. No evals, benchmarks, or paid calls were initiated. APPROVE: the scoped diff meets the requested content and consistency checks; test execution remains outside this review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed: Delegation briefs for paid model or API calls now name the exact calls or cases, the sample count, and a spend cap, and a worker that would exceed the cap stops and reports. The Human Gate line now says paid eval and benchmark runs are credit spending.
Why: A Chromeria worker ran an unrequested full eval suite and drained about 50 USD of OpenAI credits; its brief said only "use the cheapest models" and the existing gate did not stop it.
So what: Review this PR; merge stays with the user per repository policy. No release or publication in this task.
Closes #269.
Elon record
Proof
test_paid_briefs_name_scope_sample_count_and_spend_capin tests/test_operations_contract.py: red before (FAILED, 4 failures), green after.python3 -m unittest discover -s tests→ 514 tests, OK.versionctl prepare patch→ 17.4.8 to 17.4.9, mirrors and CHANGELOG updated;release-checkOK on 96f3fc0.