Skip to content

Potential fix for code scanning alert no. 5: DOM text reinterpreted as HTML #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tonytech83 merged 2 commits into from
Aug 28, 2026
Merged

Potential fix for code scanning alert no. 5: DOM text reinterpreted as HTML #8

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e72dfab
Potential fix for code scanning alert no. 5: DOM text reinterpreted a…
tonytech83 Aug 28, 2026
08415d0
Potential fix for pull request finding 'CodeQL / DOM text reinterpret…
tonytech83 Aug 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 16 additions & 5 deletions staticfiles/js/supplier-crud.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,11 +218,22 @@ document.addEventListener('DOMContentLoaded', function () {

suppliersData.forEach(function (supplier) {
let card = $('<div class="supplier-card"></div>');
card.append('<h5 class="card-title">' + supplier.name + '</h5>');
card.append('<p>Contact: ' + supplier.contact_name + '</p>');
card.append('<p>Country: ' + supplier.supplier_country + '</p>');
card.append('<p>Phone: ' + supplier.phone_number + '</p>');
card.append('<p>Email: <a href="mailto:' + supplier.email + '">' + supplier.email + '</a></p>');

card.append($('<h5 class="card-title"></h5>').text(supplier.name));
card.append($('<p></p>').text('Contact: ' + supplier.contact_name));
card.append($('<p></p>').text('Country: ' + supplier.supplier_country));
card.append($('<p></p>').text('Phone: ' + supplier.phone_number));

const emailParagraph = $('<p></p>').text('Email: ');
const rawEmail = String(supplier.email || '').trim();
const isValidEmail = /^[^\s@]+@[^\s@]+\.[^\s@]+$/.test(rawEmail);
const safeEmail = isValidEmail ? rawEmail : '';

const emailLink = $('<a></a>')
.attr('href', safeEmail ? ('mailto:' + encodeURIComponent(safeEmail)) : '#')
.text(safeEmail || rawEmail);
emailParagraph.append(emailLink);
card.append(emailParagraph);

card.on('click', function () {
showEditForm(supplier.id, supplier.name, supplier.contact_name, supplier.supplier_country, supplier.phone_number, supplier.email);
Expand Down