Skip to content

feat: add timeout configuration to API client initialization#461

Open
nikdim03 wants to merge 1 commit into
mainfrom
feature/ton-1684-emulation-timeout-android
Open

feat: add timeout configuration to API client initialization#461
nikdim03 wants to merge 1 commit into
mainfrom
feature/ton-1684-emulation-timeout-android

Conversation

@nikdim03

@nikdim03 nikdim03 commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • New Features

    • Added optional timeout configuration to Android bridge network setup.
  • Improvements

    • Enhanced network client initialization to properly apply timeout and network settings across all API clients.

@vercel

vercel Bot commented Jun 15, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
appkit-minter Ready Ready Preview, Comment Jun 15, 2026 8:21am
kit-demo-wallet Ready Ready Preview, Comment Jun 15, 2026 8:21am

Request Review

@coderabbitai

coderabbitai Bot commented Jun 15, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: fd761310-8482-4b68-b585-09e7905bef4d

📥 Commits

Reviewing files that changed from the base of the PR and between 835f505 and c56a33b.

📒 Files selected for processing (2)
  • packages/walletkit-android-bridge/src/core/initialization.ts
  • packages/walletkit-android-bridge/src/types/walletkit.ts

📝 Walkthrough

Walkthrough

Adds an optional timeout field to WalletKitBridgeInitConfig.networkConfigurations[].apiClientConfiguration and passes it into both ApiClientTonApi and ApiClientToncenter constructors inside initTonWalletKit. Also adds the missing network option to the ApiClientTonApi configuration.

Changes

Android Bridge API Client Timeout

Layer / File(s) Summary
timeout field definition and initialization wiring
packages/walletkit-android-bridge/src/types/walletkit.ts, packages/walletkit-android-bridge/src/core/initialization.ts
apiClientConfiguration gains timeout?: number; initTonWalletKit forwards it to ApiClientTonApi (with network also added) and ApiClientToncenter.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐇 Hop, hop, a timeout appears,
No more waiting through frozen years!
TonApi and Toncenter both agree,
A network field sets the clients free.
This bunny wired it, neat and right ~

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding timeout configuration to API client initialization, which is reflected in both modified files.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/ton-1684-emulation-timeout-android

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant