[tomhea]

Summary

Pre-release hardening pass over the whole codebase, following a full security/bug review.

Compiler driver (c2fj_main.py)

• Replace os.system + assert with subprocess.run(check=True) — the make invocation no longer vanishes under python -O (the call lived inside the assert), paths with spaces/shell metacharacters are passed safely (no shell), and failures raise RuntimeError instead of AssertionError.
• No more module-global mutation — make vars are built per call, so sequential/concurrent c2fj() calls can't leak SINGLE_C_FILE/ELF_OUT_PATH into each other.
• --finish-after elf|fj|fjm now requires --build-dir — previously the outputs were written into a temporary directory and silently deleted.
• Quote the per-file variables in Makefile_single_c_generic so paths with spaces survive recipe expansion (covered by a new integration test).

RISC-V translation (riscv_instructions.py, riscv_to_fj.py)

• Remove the pc_changed global; jal_op returns whether the pc changed and write_op tracks it locally.
• write_rv32m_op raises InvalidOpcode on unmatched funct3 instead of writing nothing.
• Plumb error_on_unimplemented_op through create_fj_files_from_riscv_elf (was a dead parameter).
• Fix the invalid u_type return annotation.

Linker script

• Also collect plain *(.text) input sections — objects built without -ffunction-sections (e.g. libgcc) were placed as orphan sections by heuristic.

Packaging

• Version 1.0.0 → 1.0.1.
• License id fixed to valid SPDX BSD-2-Clause (was BSD-2-Clause-Simplified, so the PyPI license classifier was wrong).
• Python support is now exactly 3.10–3.14 (>=3.10,<3.15), classifiers updated accordingly.
• Dependencies updated: pyelftools>=0.33, pytest^9, pytest-xdist^3.8 (all verified compatible with the new python range; flipjump>=1.3.0 unchanged — 1.3.0 is the latest).

CI

• tests.yml: runs on push to main too, tests a 3.10–3.14 matrix, all actions pinned to commit SHAs (the previous pmeier/pytest-results-action@main was a mutable-branch supply-chain risk).
• poetry-publish.yml: publishing is now gated on the tests passing, builds with poetry and publishes via pinned pypa/gh-action-pypi-publish. A comment notes the recommended follow-up migration to PyPI Trusted Publishing (needs one-time PyPI-side setup).

Repo hygiene & docs

• gitattributes.txt → .gitattributes (it had no effect under the old name); removed the stray empty CMakeLists.
• README: fixed --unify_fj → --unify-fj, outdated python3 c2fj.py usage → c2fj, stated supported python versions, and added a Known Limitations section (no EOF, div-by-zero exits with an error, no fence support).

Tests added

• tests/test_riscv_instructions.py — pure-python unit tests for instruction encoding: inc_pc emission for ALU/jump/branch/syscall ops, pc-state isolation between ops, invalid-op fallback vs. raise, sign_extend/fj_hex.
• tests/test_c2fj.py — new driver tests: failing make raises RuntimeError, make vars aren't mutated, finish_after without build_dir raises, compiling from a directory with spaces, and two sequential compilations (c-file then Makefile) in one process.

Test plan

• 21 new unit/driver tests pass locally (Windows, py3.11)
• Full integration suite (needs riscv64 gcc + picolibc) passes on the CI matrix 3.10–3.14

🤖 Generated with Claude Code