Apply CSP to generated status responses - #2
Merged
Conversation
Owner
Author
|
Review: LGTM ✅ Reviewed locally on top of current Verified: (Note: GitHub does not allow approving your own PR from the same account, so recording the review result here.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
content_security_policyvalue to404,405,406, and internal status responses generated byEmbeddedSpaNoneopt-out for both entry and status responsesWhy
EmbeddedSpaConfigalready validates and stores one CSP policy, but the implementation only added it to the HTML entry point. A missing immutable asset therefore returned a crate-owned404without the configured policy, creating inconsistent response coverage.Impact
Successful entry, SPA fallback, static asset, ETag, compression, cache, and body behavior are unchanged. The only observable behavior change is that crate-generated empty status responses now carry the configured CSP. Application-generated redirects and API responses remain outside this crate.
Validation
make check— 9 unit tests, 12 HTTP contract tests, Clippy with-D warnings, rustdocmake test-nginx— Nginx 1.29.8-alpine, 8 MIME types, identity/gzip/Brotli, MISS/HIT/REVALIDATED, fresh-cache 304cargo package --allow-dirty— 45 packaged files and verified package build