Fix repeated HTTP fields and qvalue parsing - #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Accept,Accept-Encoding, andIf-None-Matchfieldlines before evaluating negotiation or validators
0–1000 representation
qvalues
Why
HTTP recipients may combine repeated list-valued field lines without changing
their semantics. Reading only the first stored value could ignore a later
acceptable representation, HTML media range, or matching validator.
The former floating-point parser also clamped values outside the HTTP qvalue
grammar. For example,
1.0000could become fully acceptable even thoughsenders may emit at most three fractional digits.
Impact
The public API is unchanged. Negotiation and conditional requests now behave
consistently for repeated fields, and malformed qvalues are treated as zero
quality rather than normalized into valid preferences.
Validation
make check— 9 unit tests, 10 HTTP contract tests, Clippy with-D warnings, rustdoccargo package --allow-dirty— 45 packaged files and verified package buildmake test-nginx— Nginx 1.29.8-alpine, 8 MIME types,identity/gzip/Brotli, MISS/HIT/REVALIDATED, fresh-cache 304