Skip to content

fix(website): widen giscus comments and rename CLI step - #1542

Merged
tomalaforge merged 1 commit into
mainfrom
tomalaforge/github-login-restrictions
Aug 27, 2026
Merged

fix(website): widen giscus comments and rename CLI step#1542
tomalaforge merged 1 commit into
mainfrom
tomalaforge/github-login-restrictions

Conversation

@tomalaforge

@tomalaforge tomalaforge commented Aug 27, 2026

Copy link
Copy Markdown
Owner

Summary

  • Move max-w-3xl from the <article> element to an inner wrapper <div>, so the giscus comment thread spans the full article width instead of being capped at 48rem.
  • Rename the "One command" heading in the Try Challenge modal to Angular challenge CLI.

Summary by CodeRabbit

  • Style
    • Improved documentation page layout by constraining the document content for better readability.
  • Documentation
    • Renamed the initial “Try this challenge” setup section to “Angular challenge CLI” for clearer guidance.

Let the giscus comment thread span the full article width instead of
being capped at max-w-3xl, and rename "One command" to "Angular challenge CLI"
in the Try Challenge modal.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@vercel

vercel Bot commented Aug 27, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
angular-challenges-website Ready Ready Preview Aug 27, 2026 7:52pm

@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 8b16fa80-4d8b-4373-84e7-4d2e8639a467

📥 Commits

Reviewing files that changed from the base of the PR and between c119b88 and b65d45c.

📒 Files selected for processing (2)
  • website/src/app/pages/docs/doc-page.html
  • website/src/app/pages/docs/try-challenge.html

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.


📝 Walkthrough

Walkthrough

The document page now constrains content within a nested max-w-3xl wrapper. The first challenge setup section now uses the heading “Angular challenge CLI” and matching comment.

Changes

Document content layout

Layer / File(s) Summary
Document content width wrapper
website/src/app/pages/docs/doc-page.html
The article remains flexible. A nested max-w-3xl wrapper contains document content and closes before comments.

Challenge setup labeling

Layer / File(s) Summary
Angular challenge CLI section label
website/src/app/pages/docs/try-challenge.html
The first setup section comment and heading now use “Angular challenge CLI”.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to b65d4

The change widens the documentation comment area and renames a CLI-related heading without introducing a known correctness, security, or availability risk; no actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains both code changes, but it omits the required Challenge Submission Checklist and Important Notice sections from the repository template. Add the required checklist and Important Notice sections. Include the sponsorship information and the permitted non-sponsorship submission options from the template.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes both changes: wider Giscus comments and the renamed CLI step.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch tomalaforge/github-login-restrictions

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@tomalaforge
tomalaforge merged commit fb098eb into main Aug 27, 2026
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant