Skip to content

fix(): add missing author ioannis-tsironis and migrate to Angular v23 - #1531

Merged
tomalaforge merged 1 commit into
mainfrom
tomalaforge/fix-missing-author-ioannis-tsironis
Aug 14, 2026
Merged

fix(): add missing author ioannis-tsironis and migrate to Angular v23#1531
tomalaforge merged 1 commit into
mainfrom
tomalaforge/fix-missing-author-ioannis-tsironis

Conversation

@tomalaforge

@tomalaforge tomalaforge commented Aug 14, 2026

Copy link
Copy Markdown
Owner

Fixes a build error caused by a missing author reference: the file `Ioannis-Tsironis.json` used a capital `I`, while Astro's glob loader normalizes entry IDs to lowercase, making the actual ID `ioannis-tsironis`. Renamed the file to `ioannis-tsironis.json` and updated the `author` field in `55-back-button-navigation.md` to match. Also includes the Angular v23 NX migration: updated `package.json`, `pnpm-lock.yaml`, `nx.json`, Cypress configs, and converted `libs/decoupling` ESLint config to flat config format.

Summary by CodeRabbit

  • Updates

    • Upgraded Nx tooling to version 23.1.1.
    • Added migration support for updated Jest, Vitest, ESLint, Angular, Vite, and Cypress configurations.
    • Improved Cypress component-test consistency in CI environments.
    • Disabled workspace analytics.
  • Documentation

    • Added migration guidance for ESLint flat config, Vitest 3/4, and type-checking.
    • Corrected documentation attribution and standardized formatting.
  • Maintenance

    • Updated linting configuration for improved workspace consistency.

@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: b72e6941-7c8c-4254-b7b5-11e7b0ce34ce

📥 Commits

Reviewing files that changed from the base of the PR and between f718e25 and 947b84d.

⛔ Files ignored due to path filters (2)
  • docs/pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (21)
  • apps/forms/62-crossfield-validation-signal-form/src/test-setup.ts
  • apps/rxjs/14-race-condition/cypress.config.ts
  • apps/testing/17-router/cypress.config.ts
  • apps/testing/18-nested-components/cypress.config.ts
  • apps/testing/19-input-output/cypress.config.ts
  • apps/testing/20-modal/cypress.config.ts
  • apps/testing/29-real-life-application/cypress.config.ts
  • docs/astro.config.mjs
  • docs/src/content.config.ts
  • docs/src/content/docs/challenges/angular/55-back-button-navigation.md
  • docs/src/pages/api/sponsors.js
  • libs/decoupling/.eslintrc.json
  • libs/decoupling/eslint.config.mjs
  • migrations.json
  • nx.json
  • package.json
  • tools/ai-migrations/@nx/eslint/23.1.1/convert-to-flat-config.md
  • tools/ai-migrations/@nx/eslint/23.1.1/migrate-ban-types-rule.md
  • tools/ai-migrations/@nx/jest/23.1.1/verify-typecheck.md
  • tools/ai-migrations/@nx/vite/23.1.1/ai-instructions-for-vitest-3.md
  • tools/ai-migrations/@nx/vite/23.1.1/ai-instructions-for-vitest-4.md

📝 Walkthrough

Walkthrough

The repository upgrades Nx packages to 23.1.1, registers related migrations, adds migration guidance, updates ESLint and workspace configuration, disables Cypress just-in-time compilation, and applies formatting and documentation metadata corrections.

Changes

Nx 23.1 migration

Layer / File(s) Summary
Workspace packages and lint configuration
package.json, nx.json, libs/decoupling/eslint.config.mjs
Nx packages move to 23.1.1. Workspace lint inputs and analytics settings change. The decoupling library receives a flat ESLint configuration.
Nx migration registry
migrations.json
The registry adds Nx 23.0–23.1 migrations for Jest, JavaScript, Vitest, Devkit, ESLint, Workspace, Angular, Vite, and Cypress. Two older entries are removed.
Migration guidance
tools/ai-migrations/@nx/eslint/23.1.1/*, tools/ai-migrations/@nx/jest/23.1.1/*, tools/ai-migrations/@nx/vite/23.1.1/*
Guides describe ESLint flat-config conversion, ban-types replacement, Jest typecheck verification, and Vitest 3 and 4 migrations.
Cypress component configuration
apps/rxjs/14-race-condition/cypress.config.ts, apps/testing/*/cypress.config.ts
Six Cypress configurations set justInTimeCompile to false.

Repository formatting and metadata

Layer / File(s) Summary
Formatting and documentation metadata
apps/forms/62-crossfield-validation-signal-form/src/test-setup.ts, docs/astro.config.mjs, docs/src/content.config.ts, docs/src/content/docs/challenges/angular/55-back-button-navigation.md, docs/src/pages/api/sponsors.js
Imports and configuration structures are reformatted. The challenge author metadata is lowercased. The sponsor error response keeps its existing behavior.

Estimated code review effort: 4 (Complex) | ~45 minutes

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch tomalaforge/fix-missing-author-ioannis-tsironis

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@tomalaforge
tomalaforge merged commit 3ec9fbc into main Aug 14, 2026
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant