fix (post): uploading plain text files#302
Open
alphashuro wants to merge 1 commit into
Open
Conversation
closes tomaka#291 We were using `mutipart_field.is_text()` to branch between parsing it as a text field vs a file, but text files pass this check and then subsequently fail to parse as a text field (rightly so). This change checks for the existence of a filename instead to decide whether to parse the field as a file or text field.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #291
We were using
mutipart_field.is_text()to branch between parsing it as a text field vs a file, but text files pass this check and then subsequently fail to parse as a text field (rightly so).This change checks for the existence of a filename instead to decide whether to parse the field as a file or text field.