Skip to content

Prepare v8.0.0 release: cherry-picks & clawback - #143

Open
metalarm10 wants to merge 8 commits into
masterfrom
john/release-v8-prep
Open

metalarm10 wants to merge 8 commits into
masterfrom
john/release-v8-prep

Conversation

@metalarm10

@metalarm10 metalarm10 commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Closes: https://app.clickup.com/t/36767762/868kzdxpg

Description

Prepares master for the v8.0.0 release, so testnet and mainnet can upgrade to the same binary. Builds on master, which already includes the fixes shipping in v8 (#134, #137, #139, #140).

Cherry-picks

  • Account freeze: a fixed set of addresses cannot move funds from height 83,530,000. Enforced in the bank send hook, the delegation path and an ante check.
  • PSE skips frozen delegators: a frozen delegator is skipped during distribution instead of failing it.
  • Test timeout: raises a flaky PSE integration-test timeout from 40s to 120s.

Added functionality

  • Clawback in the v8 upgrade handler: at the upgrade height, moves the full balance of the configured accounts to their recipient, then runs module migrations.
  • Keyed by chain ID: each network only touches its own accounts - mainnet, a testnet rehearsal account, and a devnet account used by CI.
  • Upgrade test: the v7 -> v8 integration test funds the devnet account before the upgrade and checks the balance moved after it.

One binary for testnet and mainnet

  • The freeze list only matches mainnet addresses, so it has no effect on testnet or devnet.
  • No store or module version changes, so migrations only record module versions.

Testing

  • Unit tests for the freeze, the PSE skip and the clawback.
  • v7 -> v8 upgrade integration test passes with the clawback.

Reviewers checklist:

  • Try to write more meaningful comments with clear actions to be taken.
  • Nit-picking should be unblocking. Focus on core issues.

Authors checklist

  • Provide a concise and meaningful description
  • Review the code yourself first, before making the PR.
  • Annotate your PR in places that require explanation.
  • Think and try to split the PR to smaller PR if it is big.

This change is Reviewable

@metalarm10 metalarm10 changed the title <DRAFT> John/release v8 prep Prepare v8.0.0 release: cherry-picks & clawback Sep 18, 2026
@metalarm10
metalarm10 marked this pull request as ready for review September 18, 2026 14:23
@metalarm10
metalarm10 requested a review from a team as a code owner September 18, 2026 14:23
@metalarm10
metalarm10 requested review from bashash, okhlopiachyi, yivo and ysv and removed request for a team September 18, 2026 14:23
const EventTypeClawback = "clawback"

// recipient of the recovered funds on mainnet.
const recipient = "core1pnxmcuxqvumfe6ktv40v2vm3z0zckluupzxu3uuq0f7t07w6xuwsc7td3m"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let me clarify with management what should be the destination

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants