Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The microVM accept loop now claims its one boot connection before spawning a worker, closing refused peers inline without per-peer logs. This bounds worker allocation when an untrusted guest repeatedly dials the control socket; first-boot configuration and the one-connection guard remain intact.
Adds
driver.AuthorizeGuestConnection, connecting the existing runner authorization callback to the guest challenge/proof stream: strict 4 KiB framing, shared codecs, expected session/attempt correlation, one five-second ceiling, caller/host cancellation, zero authority and closed streams on failure, fixed errors, and retained buffered bytes on success. It sends only the challenge; it does not publish acceptance/configuration or install a relay.This draft depends on #115 and is stacked on
feat/guest-reconnect-session; rebase/retarget after prerequisite merges. No shipping listener invokes the new helper and no capability is enabled. Fresh current configuration, instance/epoch-bound relay handoff, configuration redemption/readiness, cold lifecycle ordering and real VM/agent qualification remain integration gates.Validation:
make verifyused disposable PostgreSQL with Docker daemon tests explicitly disabled because the required image is absent. Its only failure was the previously observed latency cleanup timing case; that case passed in isolation. Build and vet passed separately.make verify, non-root jail ownership, CLI/client race and fleet syntax gates. The built TCP/WebSocket probe passed again after CI.Commit:
7fa5fb4.Contract, alternatives and integration limits are documented in
docs/design/2026-10-01-guest-reconnect-transport.md. This is transport groundwork, not a claim of enabled live recovery or Phase B completion.