test(sending): prove billing authorization serialization - #1065
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Billing updates and final sending authorization must share the account control lock. These PostgreSQL integration tests race the real
ConsumeAttemptagainst the canonical billing transaction, covering billing-first downgrade, insertion of an absent plan, and authorization-first ordering.The tests observe actual PostgreSQL lock waits and verify billing waits at the control boundary. Full sending-policy tests pass under the race detector. Removing the authorization control lock makes the missing-plan and authorization-first tests fail. This PR changes tests only.
Independent and adversarial review passed after fixing worker cancellation/join and exclusive transaction cleanup. Final CI: 28 checks pass and one release-only check is skipped. Coverage retry passed; the first attempt reached the job time limit during the separate ramp/outbound race step after coverage tests passed.