Skip to content

fix(cli): preserve model upload rejection diagnostic - #560

Draft
cursor[bot] wants to merge 1 commit into
mainfrom
cursor/cli-command-failure-analysis-7415
Draft

fix(cli): preserve model upload rejection diagnostic#560
cursor[bot] wants to merge 1 commit into
mainfrom
cursor/cli-command-failure-analysis-7415

Conversation

@cursor

@cursor cursor Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Summary

  • replace the legacy model upload command's bare SystemExit(1) with a stable diagnostic exit
  • keep detailed API rejection text visible locally while excluding it from telemetry
  • add regression coverage for console output, exit status, and failure telemetry

The daily CLI failure export contained a current-version models upload failure reported only as status 1, despite the command already having the API's rejection message available.

Testing

  • TOGETHER_TELEMETRY_DISABLED=1 .venv/bin/python -m pytest tests/cli/test_models.py tests/cli/test_command_telemetry.py -n 0 (16 passed)
  • .venv/bin/ruff check src/together/lib/cli/api/models/upload.py tests/cli/test_models.py
  • .venv/bin/ruff format --check src/together/lib/cli/api/models/upload.py tests/cli/test_models.py
  • changed-file Pyright and mypy checks
Open in Web View Automation 

Co-authored-by: Blaine Kasten <blainekasten@gmail.com>
@broly-code-security-scanner

Copy link
Copy Markdown

Broly Security Scan

Warning

⚠️ Potential results — Broly is still completing analysis or verification. This comment will update automatically.
Files pending AI analysis: 2; findings pending verification: 0.

Note

Re-scan this PR anytime with /broly scan — useful after /broly undismiss, or to refresh findings without a new push.

Broly — SAST (zai-org/GLM-5.3-Flash) · Secrets · SCA · IaC · GH Actions · Base Images · Supply Chain Threats · Exploit Chains · Adversarial Verification

We're continuously improving Broly's accuracy and finding quality — your feedback is valuable. False positives, missed findings, bugs, and feature requests all welcome.

Ask in #security-engineering   Powered by Together AI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants