fix(stlc): back-sync on SHA ancestry, not identical trees - #550
Open
blainekasten wants to merge 1 commit into
Open
fix(stlc): back-sync on SHA ancestry, not identical trees#550blainekasten wants to merge 1 commit into
blainekasten wants to merge 1 commit into
Conversation
Tree-equal production merge commits were skipped, so staging never fast-forwarded and codegen stayed held. Compare ancestry, and if a direct FF of main is blocked by the org PR ruleset, open a merge-commit PR instead of failing closed. Co-authored-by: Blaine Kasten <blainekasten@gmail.com>
Broly Security ScanNote ✅ Clean scan Note Re-scan this PR anytime with
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SKIP_LINEAR_CHECK
Why
Python staging back-sync has been a green no-op while codegen is held.
stlc-sync.ymlskipped whenevermerge-treeof production into staging equaled staging's tree. Afterstlc/heal-promote-ancestrywas merged on both trunks, production was ahead by empty merge commits (eee6f8edvs243c5a4b) with identical trees. Generate andtrunk-sync-lockcheck ancestry, so they stayed red.Direct FF of staging
mainis also blocked by the org PR ruleset; the old job exited 1 on push failure with no PR fallback for the FF-able case.This PR
mainis rejected, open the existing heal PR (stlc/heal-promote-ancestry) and require a merge commit / FF merge, never squash.This workflow only runs on
together-py-staging. Landing it here is so promote copies the same file.Merge order
TypeScript and Go
stlc-sync.ymlhave the same tree skip; they are not currently holding generate.SKIP_LINEAR_CHECK: workflow-only fix, no SDK product change.