Skip to content

test: switch integration tests model to zai-org/GLM-5.2 (ENG-92345) - #542

Open
blainekasten wants to merge 5 commits into
mainfrom
cursor/switch-integration-tests-model-fce6
Open

test: switch integration tests model to zai-org/GLM-5.2 (ENG-92345)#542
blainekasten wants to merge 5 commits into
mainfrom
cursor/switch-integration-tests-model-fce6

Conversation

@blainekasten

@blainekasten blainekasten commented Aug 24, 2026

Copy link
Copy Markdown
Collaborator

Switches live completion integration tests from Qwen/Qwen2.5-7B-Instruct-Turbo to zai-org/GLM-5.2.

  • Shared model list is now zai-org/GLM-5.2; stream tests parametrize from it
  • Assertions tolerate Together-native and OpenAI-compatible completion shapes
  • Skip echo/logprobs, n>128, and oversized max_tokens (unsupported or too expensive on GLM-5.2)
  • Stream usage is optional (GLM omits it)
  • Cap generated tokens so the live suite fits CI

Fixes ENG-92345

Linear Issue: ENG-92345

Open in Web Open in Cursor 

Use openai/gpt-oss-20b for live completion integration tests instead of
Qwen/Qwen2.5-7B-Instruct-Turbo. Stream tests now parametrize from the
shared model list so they cannot drift.

ENG-92345

Co-authored-by: Blaine Kasten <blainekasten@gmail.com>
@broly-code-security-scanner

Copy link
Copy Markdown

Broly Security Scan

Note

Clean scan
No vulnerabilities detected in this PR.

Note

Re-scan this PR anytime with /broly scan — useful after /broly undismiss, or to refresh findings without a new push.

Broly — SAST (zai-org/GLM-5.2) · Secrets · SCA · IaC · GH Actions · Base Images · Supply Chain Threats · Exploit Chains · Adversarial Verification

We're continuously improving Broly's accuracy and finding quality — your feedback is valuable. False positives, missed findings, bugs, and feature requests all welcome.

Ask in #security-engineering   Powered by Together AI

openai/gpt-oss-20b is OpenAI-compatible: object is text_completion,
echo/logprobs are unsupported, n/penalty limits are not enforced, seed
is not echoed, oversize max_tokens is 400, and streams can end with an
empty usage chunk. Align assertions and skip Together-native checks.

Co-authored-by: Blaine Kasten <blainekasten@gmail.com>
@cursor cursor Bot changed the title test: switch integration tests model to openai/gpt-oss-20b test: switch integration tests model to openai/gpt-oss-20b (ENG-92345) Aug 24, 2026
@blainekasten
blainekasten marked this pull request as ready for review August 24, 2026 16:01
Use GLM-5.2 instead of openai/gpt-oss-20b. Re-enable Together-native
param-limit tests that gpt-oss did not enforce.

Co-authored-by: Blaine Kasten <blainekasten@gmail.com>
@cursor cursor Bot changed the title test: switch integration tests model to openai/gpt-oss-20b (ENG-92345) test: switch integration tests model to zai-org/GLM-5.2 (ENG-92345) Aug 24, 2026
cursoragent and others added 2 commits August 24, 2026 16:38
Skip n=129 and echo/logprobs (slow or unsupported), cap generated
tokens, drop the long llama prompt, and raise the integration job
timeout to 20 minutes so serverless GLM-5.2 can finish.

Co-authored-by: Blaine Kasten <blainekasten@gmail.com>
high_max_tokens was generating 200k+ tokens instead of 400ing, which
timed out the suite. GLM streams also omit usage, so only assert it
when present.

Co-authored-by: Blaine Kasten <blainekasten@gmail.com>
@blainekasten
blainekasten requested a review from zainhas August 27, 2026 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants