feat: support SHA refs for plugin specs#19
Merged
Conversation
Collaborator
|
Yeah that's better than doing branches only! Update: Don't worry about the goreleaser failure, I'll look into it. |
Pass --end-of-options before the checkout to prevent. Prevent classifying a branch/tag as a commit/SHA by always trying to resolve it as a branch/tag first. Slower but more accurate.
A symbolic-ref exit code other than 1 (e.g. not a git repo, git missing) was silently swallowed, falling through to git fetch. Return the error directly so genuine failures are reported at their source.
Collaborator
|
I pushed some changes if you would like to take a look before I merge this, nothing major just some additional safety/error handling. |
Contributor
Author
|
Yep, looks good! I was also wondering if there was a better way of identifying SHAs than just a regex which could match on weird branch or tag names and I think your solution is cleaner, so LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #18
This PR adds a feature to
tpackallowing it to support git commit SHAs.