This repository was archived by the owner on Jun 28, 2022. It is now read-only.
Include required headers in module.ac tests#11
Open
ryandesign wants to merge 1 commit into
Open
Conversation
Without these includes, functions exit, memset, strcmp, and strcpy are implicitly declared, which generates warnings. On new compilers, like the versions of clang included with Xcode 12 or later, implicitly declared functions are treated as errors, causing the configure tests to fail. The build later fails because the configure script made the wrong determinations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without these includes, functions
exit,memset,strcmp, andstrcpyare implicitly declared, which generates warnings. On new compilers, like the versions of clang included with Xcode 12 or later, implicitly declared functions are treated as errors, causing the configure tests to fail. The build later fails because the configure script made the wrong determinations.