Skip to content

chore: Switch to turborepo - #128

Open
janjakubnanista wants to merge 1 commit into
mainfrom
jan/cleanup--003
Open

chore: Switch to turborepo#128
janjakubnanista wants to merge 1 commit into
mainfrom
jan/cleanup--003

Conversation

@janjakubnanista

@janjakubnanista janjakubnanista commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

In this PR

  • Switch from cd xxx && npm i to a turbo based setup that mirrors sdk (in fact, it has been largely if not completely copied from there). This brings a lot of goodies in
  • Add TypeScript support (only affecting test files though)
  • Fix some JSDOC comments to make TypeScript happy
  • Fix JSDOM test setup so that we can remove the triplicated verifyEnclaveSignature function from tests. Basically the tests were testing that a mocked function works as expected

@socket-security

socket-security Bot commented Jul 17, 2026

Copy link
Copy Markdown

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn High
Obfuscated code: npm data-urls is 90.0% likely obfuscated

Confidence: 0.90

Location: Package overview

From: pnpm-lock.yamlnpm/jest-environment-jsdom@30.4.1npm/data-urls@5.0.0

ℹ Read more on: This package | This alert | What is obfuscated code?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/data-urls@5.0.0. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn High
Obfuscated code: npm node-forge is 90.0% likely obfuscated

Confidence: 0.90

Location: Package overview

From: pnpm-lock.yamlnpm/webpack-dev-server@5.2.2npm/node-forge@1.4.0

ℹ Read more on: This package | This alert | What is obfuscated code?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/node-forge@1.4.0. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn High
Obfuscated code: npm rrweb-cssom is 90.0% likely obfuscated

Confidence: 0.90

Location: Package overview

From: pnpm-lock.yamlnpm/jest-environment-jsdom@30.4.1npm/rrweb-cssom@0.8.0

ℹ Read more on: This package | This alert | What is obfuscated code?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/rrweb-cssom@0.8.0. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn High
Obfuscated code: npm yargs is 90.0% likely obfuscated

Confidence: 0.90

Location: Package overview

From: pnpm-lock.yamlnpm/jest@30.4.2npm/jest@29.7.0npm/yargs@17.7.3

ℹ Read more on: This package | This alert | What is obfuscated code?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/yargs@17.7.3. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

@janjakubnanista
janjakubnanista force-pushed the jan/cleanup--003 branch 3 times, most recently from 8eaad57 to 1051500 Compare July 17, 2026 23:26
@janjakubnanista
janjakubnanista force-pushed the jan/cleanup--003 branch 4 times, most recently from 786d59c to 70b668c Compare July 17, 2026 23:34
@justinformentin

Copy link
Copy Markdown

We currently have doc outlining a plan to do just this - convert to a monorepo and typescript.

We are going to approach this as a multi-step change to make it possible to review and confirm everything still works and behaves the exact same way. This is too large of a change for a single PR.

@janjakubnanista

Copy link
Copy Markdown
Contributor Author

@justinformentin same thoughts - although turbo is just one of many pieces of the puzzle.

#125 contains everything needed to get this repo up to speed:

  • turbo
  • Removing that nasty string replacement in k8s resources in favour of nginx SSI
  • Optimized Dockerfile
  • Dev setup
  • E2E tests coming

The PR is massive and the idea is to split it up into 10+ I guess steps. But to make it safe, E2E regression test suite is essential. To make things difficult, of course is much harder to add it first, then introduce turbo, but it's doable.

Also for browser testing (vitest using playwright), a runtime code change is required. The test runtime runs as an iframe, we then create yet another iframe and our iframe now triggers an error in isDoublyIframed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants