Conversation
titooan
force-pushed
the
bug1847784-fedcm-compose-theme
branch
2 times, most recently
from
August 30, 2023 21:19
ba08d2f to
7011ba0
Compare
Amejia481
reviewed
Aug 31, 2023
Comment on lines
+13
to
+18
| data class IdentityCredentialColors( | ||
| val title: Color, | ||
| val description: Color, | ||
| val ripple: Color, | ||
| ) | ||
|
|
There was a problem hiding this comment.
I was wondering if we could have a generic theme that could be used for other AC components that want to use compose, similar to what we have on FirefoxColors, we don't need something that detailed but something generic enough that could be used in other components. What do you think?
titooan
force-pushed
the
bug1842203-fedcm-provider-prompt
branch
from
August 31, 2023 19:22
f572f8f to
b7375e1
Compare
titooan
force-pushed
the
bug1847784-fedcm-compose-theme
branch
from
August 31, 2023 20:12
7011ba0 to
5ec277a
Compare
titooan
marked this pull request as draft
August 31, 2023 21:29
titooan
force-pushed
the
bug1847784-fedcm-compose-theme
branch
3 times, most recently
from
September 6, 2023 20:41
c306f5d to
fd91e12
Compare
titooan
force-pushed
the
bug1847784-fedcm-compose-theme
branch
from
September 18, 2023 18:45
fd91e12 to
c97c888
Compare
titooan
marked this pull request as ready for review
September 18, 2023 18:46
Amejia481
approved these changes
Sep 18, 2023
Amejia481
left a comment
There was a problem hiding this comment.
Thanks for putting the PR!
This looks good to me!
…dialogs in Compose
titooan
force-pushed
the
bug1842203-fedcm-provider-prompt
branch
from
September 18, 2023 18:49
b7375e1 to
53a2b6b
Compare
titooan
force-pushed
the
bug1847784-fedcm-compose-theme
branch
from
September 18, 2023 18:51
c97c888 to
ea704d4
Compare
4 tasks
titooan
force-pushed
the
bug1842203-fedcm-provider-prompt
branch
8 times, most recently
from
September 22, 2023 18:00
42f4c97 to
eadef48
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
After merge
To download an APK when reviewing a PR (after all CI tasks finished running):
Checksat the top of the PR page.firefoxci-taskclustergroup on the left to expand all tasks.build-apk-{fenix,focus,klar}-debugtask you're interested in.View task in Taskclusterin the newDETAILSsection.GitHub Automation
Used by GitHub Actions.