Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
eb74ef8
gfx: one name per uniform statement, so the Tizen emulator compiles t…
GLinnik21 Nov 20, 2026
4894d0f
Platform plan: webOS, the desktop simulators and Samsung Tizen as pla…
GLinnik21 Nov 20, 2026
e96b9c2
run_application returns its exit; only the executable entry ends the …
GLinnik21 Nov 20, 2026
73e8281
Make: a PLATFORM axis (webos, desktop, tizen), with no build change y…
GLinnik21 Nov 20, 2026
d6125c8
tv::Port becomes tv::Services; the shell and frame probes move to app…
GLinnik21 Nov 20, 2026
1adff84
Lifecycle and quit reach the loop as a HostEvent (#1484)
GLinnik21 Nov 20, 2026
d166f5f
The television's webOS-shaped types become neutral ones (#1485)
GLinnik21 Nov 20, 2026
ca76531
Keys and text reach the loop as a HostEvent with a canonical Action (…
GLinnik21 Nov 20, 2026
8f55751
The simulator runs on its own platform (#1486)
GLinnik21 Nov 20, 2026
6f4f126
The platform states where the account's records live: tv::Services.st…
GLinnik21 Nov 20, 2026
3923286
Telemetry's consent store follows the platform's storage authority, n…
GLinnik21 Nov 20, 2026
f7038a8
The platform supplies the media composition, and the app publishes it…
GLinnik21 Nov 20, 2026
f78ce7d
plex's session persistence reads the platform's storage authority ins…
GLinnik21 Nov 20, 2026
fb35a0e
Pointer and wheel reach the loop as a HostEvent, and the cursor hide …
GLinnik21 Nov 20, 2026
7a1e6c5
The docs follow where the storage authority, pointer and wheel landed…
GLinnik21 Nov 20, 2026
0354ce2
ci: fall back to OpenRouter when Claude cannot label an issue (#1495)
GLinnik21 Nov 20, 2026
2b2fb2f
docs/uri-mode.md records what the firmware does with Dolby Vision on …
GLinnik21 Nov 20, 2026
d4e1410
Item menu: Go to Movie keeps the card's focus while the menu closes (…
tiper Nov 20, 2026
be45635
Background reads of an item by rating key send skipRefresh=1 so the s…
GLinnik21 Nov 20, 2026
c43ce65
A server's library entries refresh its lists once its feed goes quiet…
GLinnik21 Nov 20, 2026
6c5ce14
The SDL shell is a crate of its own, plx_shell_sdl, behind the app-pr…
GLinnik21 Nov 20, 2026
7ceb6f7
With no playback driver composed, Detail disables what plays and ever…
GLinnik21 Nov 20, 2026
0c9a64d
The platform interface is published through one module, host, with an…
GLinnik21 Nov 21, 2026
63a923f
Merge remote-tracking branch 'upstream/main' into upstream-merge-2026…
tiper Nov 21, 2026
5ef3064
Platform axis test expects FinNative's debug app id
tiper Nov 21, 2026
fc89f2e
Search edit-key test types into the keyboard the arrival raised
claude Nov 21, 2026
331b328
Host interface test expects the FinNative window title
claude Nov 21, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .agents/agents/fw-compat-reviewer.md
Original file line number Diff line number Diff line change
Expand Up @@ -129,8 +129,8 @@ the same SONAME on every release from 2.2.3 to 11.2.0. Moving a library
into `dynlib!` **trades link-time symbol checking away** for version tolerance and is only worth
it where the version actually varies. If a diff moves a stable library there, push back and ask
for the `--inventory` output that justifies it. The precedent for the other direction is
`textinput.rs`: plain `extern "C"`, justified in its module doc by all 14 inventories exporting the
whole `SDL_*TextInput*` family.
`rust-modules/shell-sdl/src/sys.rs`: plain `extern "C"` (the `SDL_*TextInput*` calls among them),
justified in its module doc by all 14 inventories exporting every name outside its `hostsim` block.

## WHAT `fwcompat.py` NEEDS BEFORE IT WILL ANSWER — settle this first, not at your third command

Expand Down Expand Up @@ -165,7 +165,7 @@ git -C <repo> diff HEAD -- rust-modules/base/src/dynlib.rs rust-modules/media-co
rust-modules/net/src/net.rs rust-modules/net/src/curlio.rs src/starfish.c src/video_plane.c src/starfish.h \
rust-modules/os/src/webos.rs rust-modules/os/src/webos/ls2/uri.rs Makefile \
ci/expected-dt-needed.txt ci/expected-dt-needed-uri.txt
grep -rn '#\[link\|extern "C"\|__asm__("' rust-modules/src rust-modules/media/src rust-modules/play-feed/src rust-modules/play-uri/src rust-modules/os/src rust-modules/media-codecs/src rust-modules/net/src src # against the diff, not the tree
grep -rn '#\[link\|extern "C"\|__asm__("' rust-modules/src rust-modules/shell-sdl/src rust-modules/media/src rust-modules/play-feed/src rust-modules/play-uri/src rust-modules/os/src rust-modules/media-codecs/src rust-modules/net/src src # against the diff, not the tree
```

### 1. Decide, out loud, whether you are grading an ELF or grading source
Expand Down Expand Up @@ -262,7 +262,7 @@ Reading the output:
C++11 `std::string` ABI and are untested on a set apart from one 3.4.3 (webOS 1.x/2.x were never
tried). They used to fail on two missing symbols, `SDL_webOSCursorVisibility` and
`StarfishMediaAPIs::Feed`'s C++11 name, but since #578 both are `dlsym`'d at runtime
(`src/starfish.c`, `rust-modules/src/app/boot.rs`), so the binary no longer imports them. Re-run
(`src/starfish.c`, and `rust-modules/src/system.rs`'s `webos3_cursor_sleep_hint` and `cursor_door`), so the binary no longer imports them. Re-run
`tools/fwcompat.py` for what the old rows print now; they are still printed below the floor and
do not set the exit status.
* **Baseline as of 2026-08-23** (verified by running it): `15 DT_NEEDED, 319 undefined dynamic
Expand Down
2 changes: 1 addition & 1 deletion .agents/skills/ui-sim/SKILL.md
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ state. Close other WSL work, run `wsl.exe --shutdown`, and retry; accept the run
`use_gfxredir = 1`.

**Ask for `SIM_W=1920 SIM_H=1080` on any shot you intend to JUDGE.** The window is otherwise sized
to fit the display (`app::boot::plan_desktop_window`), and on a 1x screen that divisor lands on 2, so
to fit the display (`plx_shell_sdl::window::plan_desktop_window`), and on a 1x screen that divisor lands on 2, so
every screenshot comes back 960x540 — half the canvas the UI is authored at. A 1px edge-sheen, a
hairline, a snapped glyph and a specular rim are exactly the things that do not survive that
halving, which makes a shot at the default size evidence about layout and nothing else. The size is
Expand Down
4 changes: 2 additions & 2 deletions .agents/skills/which-tier/SKILL.md
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ but a photograph could show it (`gfx.rs`, at the `glBlendFuncSeparate` call).

### Tier 1 — `make check`

`cargo +$(RUST_TOOLCHAIN) test --lib -p plxnative-modules -p plx_base -p plx_machine -p plx_os -p plx_gfx -p plx_net -p plx_ui -p plx_plex -p plx_telemetry -p plx_data -p plx_session -p plx_media -p plx_playback_contract -p plx_play_uri -p plx_play_feed -p plx_media_codecs -p plx_appkit -p plx_screens -p plx_owp`, preceded by `make lint` (three **named** clippy lints —
`cargo +$(RUST_TOOLCHAIN) test --lib -p plxnative-modules -p plx_base -p plx_machine -p plx_os -p plx_gfx -p plx_net -p plx_ui -p plx_plex -p plx_telemetry -p plx_data -p plx_session -p plx_media -p plx_playback_contract -p plx_play_uri -p plx_play_feed -p plx_media_codecs -p plx_appkit -p plx_screens -p plx_shell_sdl -p plx_owp`, preceded by `make lint` (three **named** clippy lints —
`ifs_same_cond`, `same_functions_in_if_condition`, `if_same_then_else` — the shadowed-branch gate),
and followed by **three** host checks that are easy to forget are in here: `python3 ci/flavor.py
--selftest` (the flavour transform, whose central assertion is that the STABLE transform is the
Expand Down Expand Up @@ -114,7 +114,7 @@ lock.) Do not write a new number here: measure it if you need one — this file
Count it yourself if you need the number:

```sh
cd rust-modules && cargo test --lib -p plxnative-modules -p plx_base -p plx_machine -p plx_os -p plx_gfx -p plx_net -p plx_ui -p plx_plex -p plx_telemetry -p plx_data -p plx_session -p plx_media -p plx_playback_contract -p plx_play_uri -p plx_play_feed -p plx_media_codecs -p plx_appkit -p plx_screens -p plx_owp -- --list | grep -c ': test'
cd rust-modules && cargo test --lib -p plxnative-modules -p plx_base -p plx_machine -p plx_os -p plx_gfx -p plx_net -p plx_ui -p plx_plex -p plx_telemetry -p plx_data -p plx_session -p plx_media -p plx_playback_contract -p plx_play_uri -p plx_play_feed -p plx_media_codecs -p plx_appkit -p plx_screens -p plx_shell_sdl -p plx_owp -- --list | grep -c ': test'
```

**Run it on the pinned toolchain.** `make check` uses `cargo +$(RUST_TOOLCHAIN)`, the `channel` of
Expand Down
1 change: 1 addition & 0 deletions .claude/hooks/release-config-check-test.py
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ def edit(path, tool="Edit", key="file_path", **extra):
(FIRE, "the media layer crate\\'s source", edit("/repo/rust-modules/media/src/player/mod.rs"), ROOT),
(FIRE, "the appkit layer crate\\'s source", edit("/repo/rust-modules/appkit/src/player_hud/mod.rs"), ROOT),
(FIRE, "the screens layer crate\\'s source", edit("/repo/rust-modules/screens/src/home/mod.rs"), ROOT),
(FIRE, "the shell_sdl layer crate's source", edit("/repo/rust-modules/shell-sdl/src/window.rs"), ROOT),
(FIRE, "MultiEdit", edit("/repo/rust-modules/src/app/run.rs", tool="MultiEdit"), ROOT),
(FIRE, "relative to root", edit("rust-modules/src/route.rs"), ROOT),
(FIRE, "relative to a subdir", edit("src/plex/client.rs"), "/repo/rust-modules"),
Expand Down
2 changes: 1 addition & 1 deletion .claude/hooks/release-config-check.py
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,7 @@ def rust_src_target(payload, root, cwd=None):
src = os.path.realpath(os.path.join(root, "rust-modules", "src"))
# The layer crates split out of `src` (docs/module-layers.md) are compiled by the same
# `cargo check --lib` as a dependency, so an edit there is a release-configuration risk too.
layer_srcs = [os.path.realpath(os.path.join(root, "rust-modules", layer, "src")) for layer in ("base", "machine", "net", "os", "gfx", "ui", "plex", "telemetry", "data", "session", "media", "appkit", "screens")]
layer_srcs = [os.path.realpath(os.path.join(root, "rust-modules", layer, "src")) for layer in ("base", "machine", "net", "os", "gfx", "ui", "plex", "telemetry", "data", "session", "media", "appkit", "screens", "shell-sdl")]
if not any(path.startswith(s + os.sep) for s in [src] + layer_srcs):
return None
# `--lib` compiles no bin target, and `sim.rs` needs `hostsim`, which the release set never has.
Expand Down
9 changes: 5 additions & 4 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ jobs:
# (`cargo metadata` resolves; it compiles nothing), plus an informational line count.
# The binary-size budget runs in cross-build, where the binary exists. Limits and how to
# raise one deliberately: ci/build-budgets.json, docs/agent-reference.md.
run: python3 ci/check-build-budgets.py --graph --src rust-modules/src --src rust-modules/base/src --src rust-modules/machine/src --src rust-modules/net/src --src rust-modules/os/src --src rust-modules/gfx/src --src rust-modules/ui/src --src rust-modules/plex/src --src rust-modules/telemetry/src --src rust-modules/data/src --src rust-modules/session/src --src rust-modules/media/src --src rust-modules/playback-contract/src --src rust-modules/media-codecs/src --src rust-modules/play-feed/src --src rust-modules/play-uri/src --src rust-modules/appkit/src --src rust-modules/screens/src --src rust-modules/owp/src
run: python3 ci/check-build-budgets.py --graph --src rust-modules/src --src rust-modules/base/src --src rust-modules/machine/src --src rust-modules/net/src --src rust-modules/os/src --src rust-modules/gfx/src --src rust-modules/ui/src --src rust-modules/plex/src --src rust-modules/telemetry/src --src rust-modules/data/src --src rust-modules/session/src --src rust-modules/media/src --src rust-modules/playback-contract/src --src rust-modules/media-codecs/src --src rust-modules/play-feed/src --src rust-modules/play-uri/src --src rust-modules/appkit/src --src rust-modules/screens/src --src rust-modules/shell-sdl/src --src rust-modules/owp/src

- name: Third-party notices vs the ARM runtime graph
# `make check` runs only the OFFLINE half of this (ci/gen-third-party-notices.py --check), which
Expand All @@ -273,8 +273,9 @@ jobs:
- name: Type-check the simulator feature set
# The host simulator is a real build configuration with real users (the `ui-sim` skill, and
# `make macapp`, which ships `--release --no-default-features --features hostsim,play-feed` to
# somebody who has none of this installed). Nothing else in CI compiles it, so a change that
# only breaks the Mac side merges green and is found by a person trying to demo the app.
# somebody who has none of this installed). `simulators.yml` builds, links and launches it on
# macOS and Linux, in jobs that need a macOS runner and the host FFmpeg; this is the cheap early
# answer for the same feature sets, so a change that only breaks the Mac side fails here first.
run: |
cd rust-modules
cargo "+$RUST_TOOLCHAIN" check --lib --features hostsim
Expand Down Expand Up @@ -309,7 +310,7 @@ jobs:
# for plxnative-modules both ways), so the `cargo test --lib` below finds everything built
# and this step is where the compile happens, not an extra one. The upload below carries it.
shell: bash
run: cd rust-modules && cargo "+$RUST_TOOLCHAIN" test --lib -p plxnative-modules -p plx_base -p plx_machine -p plx_os -p plx_gfx -p plx_net -p plx_ui -p plx_plex -p plx_telemetry -p plx_data -p plx_session -p plx_media -p plx_playback_contract -p plx_play_uri -p plx_play_feed -p plx_media_codecs -p plx_appkit -p plx_screens -p plx_owp --no-run --timings
run: cd rust-modules && cargo "+$RUST_TOOLCHAIN" test --lib -p plxnative-modules -p plx_base -p plx_machine -p plx_os -p plx_gfx -p plx_net -p plx_ui -p plx_plex -p plx_telemetry -p plx_data -p plx_session -p plx_media -p plx_playback_contract -p plx_play_uri -p plx_play_feed -p plx_media_codecs -p plx_appkit -p plx_screens -p plx_shell_sdl -p plx_owp --no-run --timings

- name: make check-cargo-unit-default
# Teed to a file so the size step below can read the `test result:` lines this run already
Expand Down
67 changes: 63 additions & 4 deletions .github/workflows/issue-labels.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,16 +12,28 @@ name: Issue labels
#
# The issue text is never interpolated into a shell line; the script reads it from the API, and
# whatever the model answers is filtered down to the repository's own labels before anything is
# written. The token can write issues and nothing else.
# written. The GitHub token can write issues and nothing else.
#
# Claude Haiku picks the labels through the Anthropic API. The job holds no API key: it signs in with
# Claude Haiku picks the labels through the Anthropic API. The job holds no Anthropic key: it signs in with
# Workload Identity Federation (the `id-token: write` permission below; ci/label-issue.py exchanges
# GitHub's identity token for a short-lived Anthropic token). The federation rule's ids are not
# secrets; they live in the repository VARIABLES ANTHROPIC_FEDERATION_RULE_ID,
# ANTHROPIC_ORGANIZATION_ID, ANTHROPIC_SERVICE_ACCOUNT_ID and, if the rule covers several
# workspaces, ANTHROPIC_WORKSPACE_ID. The rule should accept only this repository's default branch.
# There is no keyword fallback: when sign-in or the model fails, only `user-report` is added and the
# job FAILS, so a broken rule shows up as a red run instead of weeks of silently wrong labels.
#
# Fallback: when Anthropic cannot answer (sign-in fails, or the organization is out of credit), the
# `fallback` job labels exactly the issues `label` failed on (its `failed` output) through
# OpenRouter: the same Haiku, billed from OpenRouter credit, with a non-Anthropic model as
# OpenRouter's own retry. The key is the secret OPENROUTER_API_KEY of the `issue-labels`
# ENVIRONMENT, whose deployment-branch rule admits only the default branch, so a run dispatched
# from another branch (whose copy of the script could do anything with the key) never receives it.
# It is a second job because an environment changes the job's OIDC subject from
# `...:ref:refs/heads/main`, which the federation rule matches, to `...:environment:issue-labels`:
# the Anthropic job must hold no environment, and the fallback job holds no `id-token`.
# A run that fell back finishes green and keeps `label`'s error annotations, so the Anthropic
# failure is still visible. Give the key a small credit limit on OpenRouter.
# There is no keyword fallback: when both fail, only `user-report` is added and the run FAILS, so a
# broken rule shows up as a red run instead of weeks of silently wrong labels.

on:
issues:
Expand Down Expand Up @@ -52,13 +64,18 @@ jobs:
name: label issues
runs-on: ubuntu-latest
timeout-minutes: 10
outputs:
failed: ${{ steps.label.outputs.failed }}
steps:
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
sparse-checkout: |
ci/label-issue.py
sparse-checkout-cone-mode: false
- name: Label
id: label
# A failure hands its issues to `fallback`; the check below fails the job when it did not.
continue-on-error: true
env:
GITHUB_TOKEN: ${{ github.token }}
ANTHROPIC_FEDERATION_RULE_ID: ${{ vars.ANTHROPIC_FEDERATION_RULE_ID }}
Expand Down Expand Up @@ -87,3 +104,45 @@ jobs:
[ "$ACTION" = "edited" ] && args+=(--only-if-unlabeled)
fi
python3 ci/label-issue.py "${args[@]}"
- name: Fail when no issue was handed to the fallback
# The script died before reporting which issues failed (e.g. a GitHub API error).
if: steps.label.outcome == 'failure' && steps.label.outputs.failed == ''
run: |
echo "::error::the labeler failed without naming its issues; see the Label step" >&2
exit 1

fallback:
name: label issues (OpenRouter fallback)
needs: label
if: needs.label.outputs.failed != ''
runs-on: ubuntu-latest
timeout-minutes: 10
# Holds OPENROUTER_API_KEY; its deployment-branch rule admits only the default branch.
environment: issue-labels
permissions:
contents: read
issues: write
steps:
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
sparse-checkout: |
ci/label-issue.py
sparse-checkout-cone-mode: false
- name: Label through OpenRouter
env:
GITHUB_TOKEN: ${{ github.token }}
OPENROUTER_API_KEY: ${{ secrets.OPENROUTER_API_KEY }}
FAILED: ${{ needs.label.outputs.failed }}
EVENT: ${{ github.event_name }}
DRY_RUN: ${{ inputs.dry_run }}
run: |
set -euo pipefail
args=(--provider openrouter)
[ "$EVENT" = "workflow_dispatch" ] && [ "$DRY_RUN" = "true" ] && args+=(--dry-run)
for n in $FAILED; do
case "$n" in
*[!0-9]*|'') echo "not an issue number: $n" >&2; exit 1 ;;
*) args+=(--issue "$n") ;;
esac
done
python3 ci/label-issue.py "${args[@]}"
22 changes: 21 additions & 1 deletion .github/workflows/simulators.yml
Original file line number Diff line number Diff line change
Expand Up @@ -188,10 +188,30 @@ jobs:
uses: ./.github/actions/deps-cache
- uses: Swatinem/rust-cache@d1527c8f67ef9af357290475d4af4b0fab8f12e0 # v2
with:
workspaces: rust-modules -> target-sim-ci
workspaces: |
rust-modules -> target-sim-ci
rust-modules -> target-sim-ci-macapp
key: simulator-macos
- name: Build native macOS simulator
run: make sim-macos SIM_TDIR=rust-modules/target-sim-ci
- name: Link the macOS app's feature set
# What `make macapp` ships: `--no-default-features --features hostsim,play-feed` (the
# release build in `ci/mkmacapp.py`, linked here in DEBUG: the harder case for the reliance
# below, and cheaper than a release build). The desktop platform (`platform_desktop`) never
# names the television's code, but the crate still COMPILES it (`system.rs`'s Wayland and
# SDL-private externs, `webos`, `keymanager`): a host executable links only because nothing
# references those items and the linker drops them (`-dead_strip` here, `--gc-sections` on
# Linux). A change that makes one reachable from the desktop entry fails this link on
# libwayland, glib or luna-service2, which the default-features build above may not show. This
# step guards that reliance until the platform crates split and the desktop build no longer
# contains `webos` (docs/platform-ports.md, W7). It has its own target dir because cargo does
# not hash its output: in `target-sim-ci` it would overwrite the binary the steps below run.
# The host FFmpeg and libass it links were staged by the step above.
run: |
CARGO_INCREMENTAL=0 cargo "+$(make -s print-rust-toolchain)" build \
--manifest-path rust-modules/Cargo.toml \
--target-dir rust-modules/target-sim-ci-macapp \
--no-default-features --features hostsim,play-feed --bin plxnative-sim
- name: Replay all committed product recordings
# 960x540, not the driver's 1920x1080 default. The runner has no GPU (the log says `GL:
# Apple Software Renderer`), so a replay is CPU-bound in the rasteriser and costs what the
Expand Down
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,9 @@ rust-modules/target-sim-lab/
# `make screenshots-sim` — the documentation-screenshot simulator (hostsim + devtriggers).
rust-modules/target-sim-shots/
rust-modules/target-sim-video/
# `simulators.yml` builds into `target-sim-ci` (`make sim-macos SIM_TDIR=...`) and `target-sim-ci-macapp`
# (the macapp feature set's link), in the checkout; a lane reproducing that job gets the same trees.
rust-modules/target-sim-ci*/
# pkg/plxnative-storage's own target dir, deliberately separate from $(RUST_TDIR) — see the
# Makefile's STORAGE_TDIR comment. One glob for every RELEASE/LAB/SYMBOLS combination.
rust-modules/target*-storage/
Expand Down
Loading
Loading