Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .agents/skills/cut-release/SKILL.md
Original file line number Diff line number Diff line change
Expand Up @@ -404,7 +404,7 @@ gh run view <id> --json jobs --jq '.jobs[] | "\(.name): \(.conclusion)"'
be `github-actions[bot]`, never a person:

```sh
gh api repos/GLinnik21/plx-native/releases/tags/vX.Y.Z --jq '.assets[] | "\(.name) \(.uploader.login)"'
gh api repos/plxnative/plx-native/releases/tags/vX.Y.Z --jq '.assets[] | "\(.name) \(.uploader.login)"'
```

### 5. Verify what the public can actually download
Expand All @@ -427,7 +427,7 @@ Two things are worth reading rather than assuming:

```sh
git -C . fetch origin main && git show origin/main:docs/release-audits/vX.Y.Z.md | head -40
gh api repos/GLinnik21/plx-native/releases/tags/vX.Y.Z --jq '.assets[]|"\(.name) \(.uploader.login)"'
gh api repos/plxnative/plx-native/releases/tags/vX.Y.Z --jq '.assets[]|"\(.name) \(.uploader.login)"'
```

An audit whose generated block is still the template's placeholder means the release did not go
Expand Down
8 changes: 4 additions & 4 deletions .claude/hooks/outbound-guard-test.py
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ def build_user_config(root):
(BLOCK, 'git -C /repo commit -m "wake %s first"' % FAKE_MAC), # subcommand behind -C
(BLOCK, 'git tag -a v0.3.0 -m "cut against %s"' % FAKE_TV),
(BLOCK, 'gh pr create --title "player: fix seek" --body "reproduced on %s"' % FAKE_TV),
(BLOCK, 'gh -R GLinnik21/plx-native issue comment 22 --body "user id %s"' % FAKE_USERID),
(BLOCK, 'gh -R plxnative/plx-native issue comment 22 --body "user id %s"' % FAKE_USERID),
(BLOCK, 'gh release create v0.3.0 --notes "verified against %s"' % FAKE_PMS),
(BLOCK, "gh api repos/x/y/issues/1/comments -f body='the TV is %s'" % FAKE_TV),
(BLOCK, 'gh pr comment 5 --body "token %s"' % FAKE_TOKEN),
Expand Down Expand Up @@ -162,7 +162,7 @@ def build_user_config(root):
(ALLOW, 'curl -s "http://%s:32400/library/sections?X-Plex-Token=%s"' % (FAKE_PMS, FAKE_TOKEN)),
(ALLOW, 'curl -s "https://plex.tv/api/v2/resources?X-Plex-Token=%s"' % FAKE_TOKEN),
(ALLOW, 'gh release view v0.2.1 --json body --jq .body'), # --json body is a READ
(ALLOW, 'gh api repos/GLinnik21/plx-native/releases/tags/v0.2.1 --jq ".assets[].name"'),
(ALLOW, 'gh api repos/plxnative/plx-native/releases/tags/v0.2.1 --jq ".assets[].name"'),
(ALLOW, 'gh pr view 49 --json body,title'),
(ALLOW, 'gh release download v0.2.1 -D /tmp/rel'),
(ALLOW, 'git push origin main'), # deliberately not a gate
Expand Down Expand Up @@ -257,8 +257,8 @@ def blocked(cmd, cwd=None):
(BLOCK, 'gh pr merge 5 --squash --match-head-commit %s' % GIT_SHA),
(BLOCK, 'gh pr merge --auto --squash 5'),
(BLOCK, 'gh pr merge 5 --admin'),
(BLOCK, 'gh -R GLinnik21/plx-native pr merge 5'), # the verb sits behind a global flag
(BLOCK, 'gh --repo GLinnik21/plx-native pr merge 5 --squash'),
(BLOCK, 'gh -R plxnative/plx-native pr merge 5'), # the verb sits behind a global flag
(BLOCK, 'gh --repo plxnative/plx-native pr merge 5 --squash'),
(BLOCK, 'cd /repo && gh pr merge 5 --squash'),
(BLOCK, 'make check; gh pr merge 5'),
(BLOCK, 'gh pr checks 5 --watch && gh pr merge 5'), # the chain this guard exists for
Expand Down
4 changes: 2 additions & 2 deletions .claude/hooks/outbound-guard.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

That is the shape this guards: not malice and not carelessness, but an agent being helpful with a
value it can read. A memory file is not in the loop at the moment a PR body is composed; a
PreToolUse hook is. github.com/GLinnik21/plx-native is PUBLIC.
PreToolUse hook is. github.com/plxnative/plx-native is PUBLIC.

WHAT IT COSTS. Classification is pure string work over the command line, and nothing is opened —
not the gitignored files, not even the repo root — unless a segment is first graded outbound, so
Expand Down Expand Up @@ -1292,7 +1292,7 @@ def main():
lines.append(" (the value itself is not printed — putting it in this transcript is the same "
"leak by a shorter route)")
sys.stderr.write("\n".join(lines) + "\n\n" + (
"github.com/GLinnik21/plx-native is PUBLIC. On 2026-08-14 four PR bodies (#28-31) carried a\n"
"github.com/plxnative/plx-native is PUBLIC. On 2026-08-14 four PR bodies (#28-31) carried a\n"
"third party's Plex server address, port, machineIdentifier and handle. All four were\n"
"redacted, but GitHub keeps PR-body edit history, so those values are permanently public —\n"
"and they were the FRIEND's, not this project's to publish.\n"
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/build-bench.yml
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ concurrency:
jobs:
measure:
name: Time the build on a macOS runner (${{ matrix.leg }})
if: github.repository == 'GLinnik21/plx-native' && github.ref_name == github.event.repository.default_branch
if: github.repository == 'plxnative/plx-native' && github.ref_name == github.event.repository.default_branch
runs-on: macos-latest
strategy:
# A leg that fails must not cancel the other: its rows are still worth having.
Expand Down Expand Up @@ -175,7 +175,7 @@ jobs:
gate:
name: Time the whole host gate on a macOS runner
# Not for a narrowed manual run (`only`), which asked for something else.
if: github.repository == 'GLinnik21/plx-native' && github.ref_name == github.event.repository.default_branch && !inputs.only
if: github.repository == 'plxnative/plx-native' && github.ref_name == github.event.repository.default_branch && !inputs.only
runs-on: macos-latest
permissions:
contents: read
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/fuzz.yml
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ jobs:
fuzz:
name: build every target and fuzz
# A fork's scheduled run would fuzz for nobody; a fork's PR is still built.
if: github.event_name == 'pull_request' || github.repository == 'GLinnik21/plx-native'
if: github.event_name == 'pull_request' || github.repository == 'plxnative/plx-native'
runs-on: ubuntu-24.04
timeout-minutes: 120
steps:
Expand Down
29 changes: 13 additions & 16 deletions .github/workflows/issue-labels.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,14 @@ name: Issue labels
# whatever the model answers is filtered down to the repository's own labels before anything is
# written. The token can write issues and nothing else.
#
# A model picks the labels when the repository has a `COPILOT_GITHUB_TOKEN` Actions secret (a
# fine-grained personal access token with the "Copilot Requests" permission; Copilot Free works) or
# an `ANTHROPIC_API_KEY` one. Without either the job still runs and labels from keyword rules (one
# kind, one area, `user-report`).
# Claude Haiku picks the labels through the Anthropic API. The job holds no API key: it signs in with
# Workload Identity Federation (the `id-token: write` permission below; ci/label-issue.py exchanges
# GitHub's identity token for a short-lived Anthropic token). The federation rule's ids are not
# secrets; they live in the repository VARIABLES ANTHROPIC_FEDERATION_RULE_ID,
# ANTHROPIC_ORGANIZATION_ID, ANTHROPIC_SERVICE_ACCOUNT_ID and, if the rule covers several
# workspaces, ANTHROPIC_WORKSPACE_ID. The rule should accept only this repository's default branch.
# There is no keyword fallback: when sign-in or the model fails, only `user-report` is added and the
# job FAILS, so a broken rule shows up as a red run instead of weeks of silently wrong labels.

on:
issues:
Expand All @@ -37,6 +41,7 @@ on:
permissions:
contents: read
issues: write
id-token: write

concurrency:
group: issue-labels-${{ github.event.issue.number || github.run_id }}
Expand All @@ -47,27 +52,19 @@ jobs:
name: label issues
runs-on: ubuntu-latest
timeout-minutes: 10
env:
HAS_COPILOT: ${{ secrets.COPILOT_GITHUB_TOKEN != '' }}
steps:
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
sparse-checkout: |
ci/label-issue.py
tools/package.json
tools/package-lock.json
sparse-checkout-cone-mode: false
- name: Install the Copilot CLI
if: env.HAS_COPILOT == 'true'
# The version pinned in tools/package.json (Dependabot bumps it with its lockfile); ci/label-issue.py finds `copilot` on PATH.
run: |
npm ci --prefix tools
echo "$PWD/tools/node_modules/.bin" >> "$GITHUB_PATH"
- name: Label
env:
GITHUB_TOKEN: ${{ github.token }}
COPILOT_GITHUB_TOKEN: ${{ secrets.COPILOT_GITHUB_TOKEN }}
ANTHROPIC_API_KEY: ${{ secrets.ANTHROPIC_API_KEY }}
ANTHROPIC_FEDERATION_RULE_ID: ${{ vars.ANTHROPIC_FEDERATION_RULE_ID }}
ANTHROPIC_ORGANIZATION_ID: ${{ vars.ANTHROPIC_ORGANIZATION_ID }}
ANTHROPIC_SERVICE_ACCOUNT_ID: ${{ vars.ANTHROPIC_SERVICE_ACCOUNT_ID }}
ANTHROPIC_WORKSPACE_ID: ${{ vars.ANTHROPIC_WORKSPACE_ID }}
EVENT: ${{ github.event_name }}
ACTION: ${{ github.event.action }}
ISSUE: ${{ github.event.issue.number }}
Expand Down
52 changes: 36 additions & 16 deletions .github/workflows/nightly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,16 @@ name: Nightly
# nightly's PACKAGE version carries its cut date (`ci/flavor.py`), which is what makes Homebrew
# Channel offer the next one as an update. `docs/nightly-builds.md` is the user-facing guide.
#
# The release itself is published to its own repository, `plxnative/plx-native-nightly`
# (`ci/nightly.py`'s `RELEASE_REPO`), so watching this repository's releases announces real releases
# only. The `nightly/v*` TAG is still pushed here, at the commit built: `plan` diffs against the
# previous one and the notes' compare link spans two. Writing to the other repository needs the
# `NIGHTLY_RELEASE_TOKEN` secret, a fine-grained token owned by the organization with Contents:
# read and write on that one repository; `GITHUB_TOKEN` can write only here.
#
# `plan` decides the day's version and whether there is anything to build; `build` reuses the same
# ARM build+verify pipeline release.yml also uses (`build-package.yml`); `publish` is the only job
# that can write to the repo's releases; `pages` refreshes the site's "latest nightly" pointer the
# that can write nightly releases; `pages` refreshes the site's "latest nightly" pointer the
# same day a nightly ships rather than waiting for an unrelated site/docs push; `prune` deletes
# nightly releases (and their tags) past their 30-day retention, always keeping the newest one even
# if the schedule went quiet for longer than that.
Expand Down Expand Up @@ -239,20 +246,22 @@ jobs:
fetch-depth: 0
- name: Refuse to overwrite an immutable nightly
# `ci/nightly.py plan` already checked the LOCAL tag list at plan time; this re-checks
# against the remote right before publishing, belt-and-suspenders because plan and publish
# against the remotes right before publishing, belt-and-suspenders because plan and publish
# run minutes apart and a concurrent run (or a hand-pushed tag) could land in between.
# Pointless (and a needless GH_TOKEN use) in a dry run, which never reaches
# Pointless (and a needless token use) in a dry run, which never reaches
# `gh release create` and has no tag to protect.
if: ${{ needs.plan.outputs.dry != 'true' }}
env:
TAG: ${{ needs.plan.outputs.tag }}
GH_TOKEN: ${{ github.token }}
GH_TOKEN: ${{ secrets.NIGHTLY_RELEASE_TOKEN }}
run: |
set -euo pipefail
test -n "$GH_TOKEN" || { echo "::error::NIGHTLY_RELEASE_TOKEN is required to publish to $(python3 ci/nightly.py release-repo)"; exit 1; }
release_repo=$(python3 ci/nightly.py release-repo)
! git ls-remote --exit-code --tags origin "refs/tags/$TAG" >/dev/null \
|| { echo "::error::$TAG already exists — nightly rebuilds of the same day are refused by design."; exit 1; }
! gh release view "$TAG" >/dev/null 2>&1 \
|| { echo "::error::release $TAG already exists."; exit 1; }
! gh release view "$TAG" --repo "$release_repo" >/dev/null 2>&1 \
|| { echo "::error::release $TAG already exists in $release_repo."; exit 1; }
- uses: actions/download-artifact@9000827ccba6bdab643e8b6fd33ac0654aef8333 # v8.0.2
with:
name: nightly-assets
Expand Down Expand Up @@ -310,33 +319,41 @@ jobs:
- name: Create and verify the nightly prerelease
if: ${{ needs.plan.outputs.dry != 'true' }}
env:
GH_TOKEN: ${{ github.token }}
GH_TOKEN: ${{ secrets.NIGHTLY_RELEASE_TOKEN }}
TAG: ${{ needs.plan.outputs.tag }}
LABEL: ${{ needs.plan.outputs.label }}
SHA: ${{ needs.plan.outputs.sha }}
IPK: ${{ steps.stage.outputs.ipk }}
run: |
set -euo pipefail
gh release create "$TAG" \
release_repo=$(python3 ci/nightly.py release-repo)
# The tag goes here first, at the commit built, through the checkout's own credentials
# (this job's GITHUB_TOKEN). If the release then fails to publish, the tag is taken back
# so a re-run is not refused as a same-day rebuild.
git tag "$TAG" "$SHA"
git push origin "refs/tags/$TAG"
trap 'git push --delete origin "refs/tags/$TAG" || true' ERR
# The release repository has none of this repository's commits, so its own copy of the
# tag sits on its `main`; the built commit is the tag above, which the notes link.
gh release create "$TAG" --repo "$release_repo" \
"dist/$IPK" dist/nightly.sha256 dist/io.github.tiper.finnative.nightly.manifest.json dist/ffmpeg-*.tar.xz dist/build-ffmpeg.sh dist/finnative-source-*.tar.gz* \
--target "$SHA" \
--target main \
--title "PlxNative $LABEL" \
--prerelease \
--latest=false \
--notes-file "$RUNNER_TEMP/notes.md"
trap - ERR
# Re-derive every published claim from the live release rather than trusting
# `gh release create`'s own exit code: prerelease, target sha, uploader, and the
# downloaded bytes hashing to what was staged.
test "$(gh api "repos/$GITHUB_REPOSITORY/releases/tags/$TAG" --jq .prerelease)" = true
test "$(gh api "repos/$GITHUB_REPOSITORY/releases/tags/$TAG" --jq .target_commitish)" = "$SHA"
# `gh release create`'s own exit code: prerelease, the tag here naming the built commit,
# and the downloaded bytes hashing to what was staged.
test "$(gh api "repos/$release_repo/releases/tags/$TAG" --jq .prerelease)" = true
test "$(git ls-remote --tags origin "refs/tags/$TAG" | awk '{print $1}')" = "$SHA"
test "$(gh api "repos/$GITHUB_REPOSITORY/releases/tags/$TAG" --jq '.assets[0].uploader.login')" = 'github-actions[bot]'
mkdir -p verify
gh release download "$TAG" --pattern "$IPK" --dir verify
gh release download "$TAG" --repo "$release_repo" --pattern "$IPK" --dir verify
test "$(sha256sum "verify/$IPK" | cut -d' ' -f1)" = "$(cut -d' ' -f1 dist/nightly.sha256)"
# The published manifest must name the published package's hash — the one thing the
# television checks on install.
gh release download "$TAG" --pattern io.github.tiper.finnative.nightly.manifest.json --dir verify
gh release download "$TAG" --repo "$release_repo" --pattern io.github.tiper.finnative.nightly.manifest.json --dir verify
test "$(python3 -c "import json;print(json.load(open('verify/io.github.tiper.finnative.nightly.manifest.json'))['ipkHash']['sha256'])")" = "$(cut -d' ' -f1 dist/nightly.sha256)"

pages:
Expand Down Expand Up @@ -365,5 +382,8 @@ jobs:
with:
ref: ${{ needs.plan.outputs.sha }}
- env:
# GITHUB_TOKEN deletes this repository's tags (and its pre-move nightly releases);
# NIGHTLY_RELEASE_TOKEN deletes releases in the release repository.
GH_TOKEN: ${{ github.token }}
NIGHTLY_RELEASE_TOKEN: ${{ secrets.NIGHTLY_RELEASE_TOKEN }}
run: python3 ci/nightly.py prune --repo "${{ github.repository }}" --days 30
1 change: 1 addition & 0 deletions .github/workflows/simulators.yml
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,7 @@ jobs:
path: |
${{ runner.temp }}/plxnative-replay/**/plxnative-events.log
${{ runner.temp }}/plxnative-replay/**/sim.out
${{ runner.temp }}/plxnative-replay/**/process.json
if-no-files-found: ignore
retention-days: 7
- name: Launch and capture 1080p frame
Expand Down
4 changes: 1 addition & 3 deletions ci/allow/forks/screens.txt
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
# count: 5
# count: 3
# Test/production forks (docs/sans-io.md), area `screens`: one line per production-visible `#[cfg(..)]` / `cfg!(..)` whose predicate reads `test` or `feature = "test-support"`
# (`not(test)`, `not(any(test, feature = "test-support"))`, ...) in every machine crate (data/, plex/, media/, session/, screens/, ui/, appkit/ and machine/), keyed `<path>::<item name>` (an attribute on an item), `<path>::<enclosing fn>` (a statement or an inline `cfg!`) or `<path>::<struct>` (a field).
# Logic is one thing in production and tests deliver it events: there is no cfg(test) fork. Spec: ci/check-deps.sh `forks`.
# The gate compares this list to the tree as an exact multiset: a new site fails it, and so does a line whose site is gone, so it only shrinks. A migration lands by deleting its lines; do not add one to make a new site pass.
rust-modules/screens/src/consent/finnative.rs::reporting_configured
rust-modules/screens/src/consent/finnative.rs::reporting_configured
rust-modules/screens/src/legal.rs::build_sha
rust-modules/screens/src/library/lookahead.rs::rows
rust-modules/screens/src/login.rs::harness_driven
3 changes: 1 addition & 2 deletions ci/allow/forks/ui.txt
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
# count: 13
# count: 12
# Test/production forks (docs/sans-io.md), area `ui`: one line per production-visible `#[cfg(..)]` / `cfg!(..)` whose predicate reads `test` or `feature = "test-support"`
# (`not(test)`, `not(any(test, feature = "test-support"))`, ...) in every machine crate (data/, plex/, media/, session/, screens/, ui/, appkit/ and machine/), keyed `<path>::<item name>` (an attribute on an item), `<path>::<enclosing fn>` (a statement or an inline `cfg!`) or `<path>::<struct>` (a field).
# Logic is one thing in production and tests deliver it events: there is no cfg(test) fork. Spec: ci/check-deps.sh `forks`.
# The gate compares this list to the tree as an exact multiset: a new site fails it, and so does a line whose site is gone, so it only shrinks. A migration lands by deleting its lines; do not add one to make a new site pass.
rust-modules/ui/src/card_motion.rs::enforced_limit
rust-modules/ui/src/containers/modal.rs::kick
rust-modules/ui/src/containers/transition.rs::PageImage
rust-modules/ui/src/containers/transition.rs::plan
Expand Down
22 changes: 6 additions & 16 deletions ci/allow/fxlanes/app.txt
Original file line number Diff line number Diff line change
@@ -1,16 +1,6 @@
# count: 11
# Bridge::app_effect arms off the ordered lane (docs/sans-io.md), area `app`: one line per `AppFx::<Variant>` arm that does not push `Fx::Deliver(..)`,
# keyed `<path>::AppFx::<Variant>`. An arm that parks its request on a side queue of the bridge is a second lane with its own timing; a result returns as one addressed event on the FIFO.
# Spec: ci/check-deps.sh `fxlanes`.
# The gate compares this list to the tree as an exact multiset: a new site fails it, and so does a line whose site is gone, so it only shrinks. A migration lands by deleting its lines; do not add one to make a new site pass.
rust-modules/src/app/bridge.rs::AppFx::Catalog
rust-modules/src/app/bridge.rs::AppFx::Content
rust-modules/src/app/bridge.rs::AppFx::Home
rust-modules/src/app/bridge.rs::AppFx::ItemMenu
rust-modules/src/app/bridge.rs::AppFx::Library
rust-modules/src/app/bridge.rs::AppFx::Loop
rust-modules/src/app/bridge.rs::AppFx::Player
rust-modules/src/app/bridge.rs::AppFx::Preferences
rust-modules/src/app/bridge.rs::AppFx::Search
rust-modules/src/app/bridge.rs::AppFx::SessionEffect
rust-modules/src/app/bridge.rs::AppFx::Watchlist
# count: 0
# Bridge::app_effect arms off the ordered lane (docs/sans-io.md), area `app`.
# Direct deliveries stay on the dispatcher FIFO. External variants must be unreachable here,
# explicitly classified to yield, and handled by the taken-head runner; check-app-command-routing.py
# proves that contract before the exact fxlanes scan accepts an unreachable arm.
# New side queues or unproved arms fail; this ledger only shrinks.
Loading
Loading