Repository navigation
test: rename legacy test.rs and *_test.rs files to *_tests.rs - #8
Conversation
Each module keeps its name; its declaration gains a #[path] to the renamed file. Only names change, no test code does. Drops the legacy-files note from the guidance. Co-authored-by: Medulla <medulla@tinyhumans.ai>
…o legacy-test-renames
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (27)
💤 Files with no reviewable changes (1)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughTest module declarations across the tinysearch crates now specify their source files with path attributes. Repository guidance no longer requires renaming existing test files when they are touched. ChangesTest Module Source Paths
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~4 minutes Change: Other Merge Risk: ⚪ Minimal · up to This change redirects test-module loading to renamed files without an indicated production behavior change. The reported test-target check passed, and no actionable merge risk remains. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 2 systems. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
A rabbit checks each test path twice, Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Tiny Sweeper reviewTiny Sweeper reviewed this change across 6 lane(s) and found 0 active actionable finding(s). Detailed lane evidence and any incomplete work are listed below. State: Incomplete Review snapshot
Completeness: Incomplete What changedThe review could not produce a supported behavioral summary; inspect the cited changed surface and lane details below. FeaturesNone identified with supported citations. TestsNo supported feature-to-test mapping was produced. Test execution is not inferred.
FindingsNo active actionable findings. Could not review: crates/tinysearch-bus/src/errors/mod.rs, crates/tinysearch-bus/src/names/mod.rs, crates/tinysearch-bus/src/search/catalog/mod.rs, crates/tinysearch-bus/src/search/mod.rs, crates/tinysearch-bus/src/version/mod.rs, crates/tinysearch/src/error/mod.rs, crates/tinysearch/src/provider/direct/parallel.rs, crates/tinysearch/src/provider/direct/tavily.rs, crates/tinysearch/src/provider/direct/tinyfish.rs, crates/tinysearch/src/provider/mod.rs, crates/tinysearch/src/search/mod.rs, crates/tinysearch/src/search/roles/mod.rs, crates/tinysearch/src/tinybus_module/mod.rs, tinysweeper/description, tinysweeper/tests Before merge
How this fits togetherflowchart LR
n0["select_tools<br/>changed"]:::changed
n1["Error<br/>changed"]:::changed
n2["async_response<br/>changed"]:::changed
n3["as_str"]:::impacted
n4["all_tools_catalog_is_direct_only"]:::impacted
n5["configured_provider_tools"]:::impacted
n6["provider_tool_specs"]:::impacted
n7["roles_mode_lists_one_tool_per_served_role"]:::impacted
n8["...ackend_credential_drops_backend_providers"]:::impacted
n2 -->|calls| n3
n2 -->|uses| n3
n4 -->|uses| n1
n4 -->|calls| n3
n4 -->|tests| n3
n5 -->|calls| n3
n7 -->|calls| n0
n7 -->|tests| n0
n7 -->|calls| n5
n7 -->|tests| n5
n7 -->|calls| n6
n7 -->|tests| n6
n8 -->|calls| n0
n8 -->|tests| n0
n8 -->|calls| n5
n8 -->|tests| n5
n8 -->|calls| n6
n8 -->|tests| n6
classDef changed fill:#0d4429,stroke:#238636,color:#e6edf3
classDef impacted fill:#161b22,stroke:#6e7681,color:#c9d1d9
classDef flagged fill:#5a1e02,stroke:#d93f0b,color:#ffffff
classDef blocking fill:#67060c,stroke:#f85149,color:#ffffff
Agent review detailscritique
security
tests
commits
description
e2e
Evidence and run details
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
![tinysweeper[bot]](https://avatars.githubusercontent.com/in/4526585?s=60&v=4){kind=small}
There was a problem hiding this comment.
tinysweeper found nothing blocking, but could not review everything, so this is not an approval: crates/tinysearch-bus/src/errors/mod.rs, crates/tinysearch-bus/src/names/mod.rs, crates/tinysearch-bus/src/search/catalog/mod.rs, crates/tinysearch-bus/src/search/mod.rs, crates/tinysearch-bus/src/version/mod.rs, crates/tinysearch/src/error/mod.rs, crates/tinysearch/src/provider/direct/parallel.rs, crates/tinysearch/src/provider/direct/tavily.rs and 7 more.
$0.0000 · 0 in / 0 out · 597 embedded · ladder/vectors
1 participant
Summary
Renames 13 legacy test files (
test.rsand<name>_test.rs) to<module>_tests.rs(test.rsbecomes<declaring file>_tests.rs,mod_tests.rsbeside amod.rs). Each module keeps its identifier, so references to it keep resolving; its declaration gains a#[path]to the renamed file. Only file names and those attributes change, no test code. Removes the now-stale "legacy files" note from the guidance. Done with OpenHuman'sscripts/externalize-inline-tests.mjs --rename-legacy.Related issue
None.
API or behavior changes
None. Test-only files renamed; no public API or runtime behavior changes.
Validation
Commands actually run, with their outcome:
cargo fmt --all -- --check(clean)cargo clippy --all-targets --all-features -- -D warnings(left to CI)cargo check --workspace --tests(passes;cargo build/cargo testleft to CI)cargo test --all-features(left to CI)Tests
No tests added or changed; 13 files renamed. Test bodies are untouched (git detects them as renames).
Documentation
CLAUDE.md/AGENTS.mdupdated.Checklist
#[allow(...)],#[ignore], or relaxed lints.envcontents in the diff or the descriptionSummary by CodeRabbit