Skip to content

Use adaptive HTTP/2 windows for the remote cache connection #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
senamakel merged 3 commits into from
Oct 15, 2026
Merged

Use adaptive HTTP/2 windows for the remote cache connection #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dc79db4
chore: files changed crates/tinymold-remote/src/client/mod.rs
senamakel Oct 15, 2026
6824ac2
perf(remote): use adaptive HTTP/2 windows for the cache connection
senamakel Oct 15, 2026
06094be
docs(remote): state the window limit as a bound, not a measurement
senamakel Oct 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion crates/tinymold-remote/src/client/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,12 @@ impl Client {
pub(crate) fn new(config: &RemoteConfig) -> Result<Self> {
let mut endpoint = Endpoint::from_shared(config.endpoint.clone())
.map_err(Error::Connect)?
.connect_timeout(config.timeout);
.connect_timeout(config.timeout)
// With hyper's fixed windows (2 MiB a stream, 5 MiB a
// connection), a read can move at most one window per round
// trip, however fast the link; adaptive windows grow to the
// bandwidth-delay product.
.http2_adaptive_window(true);
if config.uses_tls() {
endpoint = endpoint
.tls_config(ClientTlsConfig::new().with_webpki_roots())
Expand Down
4 changes: 3 additions & 1 deletion docs/specs/remote.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,9 @@ sharing a key.
outcome is `remote`.

Calls go through ByteStream `Read` for blobs, so blob size is not limited
by the gRPC message size. Once an entry's signature checks out, its
by the gRPC message size. The connection uses HTTP/2 adaptive flow-control
windows, so reads from a distant cache are not held to a fixed window per
round trip. Once an entry's signature checks out, its
objects and its record are read together, within the same limits as a
push's uploads (below), and a pre-key
lookup reads its signature and record together: each read is a round trip,
Expand Down
Loading