Repository navigation
chore(deps): bump tinytools (NetGate::authorize_destination, address pinning) - #468
Conversation
Update the vendored tinytools submodule to the latest commit. Auto-committed-on: dragonfly
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing: 1
Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4891f8df36
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -1 +1 @@ | |||
| Subproject commit 201c563219549114da3dffcfc8ef75f3eb2e130c | |||
| Subproject commit 83757a903ba1689ad3cde3397e85a275401fc36e | |||
There was a problem hiding this comment.
Preserve address pinning when requests use a proxy
When HTTP(S)_PROXY is set or NetGate::prepare_client installs a proxy, reqwest connects to that proxy rather than the address supplied through resolve_to_addrs; its documentation explicitly notes that an intercepted request talks to the proxy. A target-resolving HTTP CONNECT or SOCKS5h proxy can therefore resolve an attacker-controlled hostname to a private address after authorize_destination approved a public one, defeating the security guarantee introduced by this gitlink bump for all proxy-enabled deployments. Disable such proxies for pinned requests or pass the vetted address through a proxy mechanism that cannot re-resolve the hostname, and cover that configuration with a regression test.
AGENTS.md reference: AGENTS.md:L74-L82
Useful? React with 👍 / 👎.
Tiny Sweeper reviewTiny Sweeper reviewed this change across 5 lane(s) and found 0 active actionable finding(s). Detailed lane evidence and any incomplete work are listed below. State: Ready for maintainer review Review snapshot
Completeness: Complete FeaturesNone identified with supported citations. TestsNo supported feature-to-test mapping was produced. Test execution is not inferred. FindingsNo active actionable findings. Before mergeNone. Agent review detailscritique
security
tests
commits
description
Evidence and run details
|
Part of tinyhumansai/openhuman#7328.
Moves the vendored tinytools gitlink to 83757a9 (tinyhumansai/tinytools#71): the network tools (
http_request,web_fetch,curl) now connect only to vetted addresses and a host can authorize destinations throughNetGate::authorize_destination(default unchanged), so OpenHuman can put its security module's URL guard in front of them instead of a per-tool DNS check.No code change in this repository; the gitlink is the whole diff.
Summary by CodeRabbit