Skip to content

chore(deps): bump tinytools (NetGate::authorize_destination, address pinning) - #468

Merged
senamakel merged 1 commit into
mainfrom
security-bus-7328-tinytools-destination
Oct 15, 2026
Merged

senamakel merged 1 commit into
mainfrom
security-bus-7328-tinytools-destination

Conversation

@senamakel

@senamakel senamakel commented Oct 15, 2026 •

Copy link
Copy Markdown
Member

Part of tinyhumansai/openhuman#7328.

Moves the vendored tinytools gitlink to 83757a9 (tinyhumansai/tinytools#71): the network tools (http_request, web_fetch, curl) now connect only to vetted addresses and a host can authorize destinations through NetGate::authorize_destination (default unchanged), so OpenHuman can put its security module's URL guard in front of them instead of a per-tool DNS check.

No code change in this repository; the gitlink is the whole diff.

Summary by CodeRabbit

  • Chores
    • Updated the bundled Tinytools component to a newer revision. No changes to public interfaces or user-facing behavior are reported. The available summary does not identify any new features, bug fixes, or other visible changes.

Update the vendored tinytools submodule to the latest commit.

Auto-committed-on: dragonfly
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-15T18:33:10.632568Z 4891f8d PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 15, 2026

Copy link
Copy Markdown

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: f2a09da9-aa0d-482d-92a0-4beea2efc153
📥 Commits

Reviewing files that changed from the base of the PR and between 5f6dce5 and 4891f8d.

📒 Files selected for processing: 1
  • vendor/tinytools
+------------------------------------------+
| Performing energy-intensive code review. |
+------------------------------------------+
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4891f8df36

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread vendor/tinytools
@@ -1 +1 @@
Subproject commit 201c563219549114da3dffcfc8ef75f3eb2e130c
Subproject commit 83757a903ba1689ad3cde3397e85a275401fc36e

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve address pinning when requests use a proxy

When HTTP(S)_PROXY is set or NetGate::prepare_client installs a proxy, reqwest connects to that proxy rather than the address supplied through resolve_to_addrs; its documentation explicitly notes that an intercepted request talks to the proxy. A target-resolving HTTP CONNECT or SOCKS5h proxy can therefore resolve an attacker-controlled hostname to a private address after authorize_destination approved a public one, defeating the security guarantee introduced by this gitlink bump for all proxy-enabled deployments. Disable such proxies for pinned requests or pass the vetted address through a proxy mechanism that cannot re-resolve the hostname, and cover that configuration with a regression test.

AGENTS.md reference: AGENTS.md:L74-L82

Useful? React with 👍 / 👎.

@tinysweeper

tinysweeper Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Tiny Sweeper review

Tiny Sweeper reviewed this change across 5 lane(s) and found 0 active actionable finding(s). Detailed lane evidence and any incomplete work are listed below.

State: Ready for maintainer review
Priority: none
Reviewed head: 4891f8df363d
Updated: 2026-10-15T18:33:37Z

Review snapshot

Change surface Files Review signal Count
Production 0 Active findings 0
Tests 0 Noted findings 0
Documentation 0 Resolved findings 0
Configuration 0 Pending checks/questions 0

Completeness: Complete
Test assessment: No supported feature-to-test mapping was available; this does not mean tests are absent or passed.

Features

None identified with supported citations.

Tests

No supported feature-to-test mapping was produced. Test execution is not inferred.

Findings

No active actionable findings.

Before merge

None.

Agent review details

critique

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Lane summary: No added or modified lines to review.

security

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Lane summary: No added or modified lines to review.

tests

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Lane summary: No added or modified lines to review.

commits

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Lane summary: Nothing sensitive found in what this pull request commits.

description

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Lane summary: No added or modified lines to review.
Evidence and run details
  • Models: ladder/vectors-oai3
  • Spend: $0.000002
  • Tokens: 0 input · 0 output · 0 cached · 19 embedding
Head State Pass summary
4891f8df363d ready for maintainer review 0 active finding(s), 0 resolved finding(s) (at 2026-10-15T18:33:37Z)

tinysweeper 0.1.2

@tinysweeper tinysweeper Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tinysweeper found nothing blocking. Approving.

$0.0000 · 0 in / 0 out · 19 embedded · ladder/vectors-oai3

@tinysweeper tinysweeper Bot added the priority: p3 Whenever. Cosmetic, a nicety, or a cleanup with no user visible effect. label Oct 15, 2026
@senamakel
senamakel merged commit 096a280 into main Oct 15, 2026
16 of 17 checks passed
@senamakel
senamakel deleted the security-bus-7328-tinytools-destination branch October 17, 2026 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority: p3 Whenever. Cosmetic, a nicety, or a cleanup with no user visible effect.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant