Repository navigation
fix(core): drop DispatchCtx leftovers that fail clippy -D warnings - #7912
Merged
M3gA-Mind merged 2 commits intoOct 16, 2026
Merged
Conversation
Remove 8 unused config_rpc imports, pass ctx instead of &ctx where it is already a &DispatchCtx (task_sources route, wallet tools), and collapse a redundant async block in the embed flow_approvals test.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 3 files. |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
| Description Check | |
Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | |
The title clearly summarizes the pull request's main change: removing DispatchCtx migration leftovers and related clippy warnings in core code. |
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
A rabbit checks the context pass,
Then hops through imports trimmed from grass.
It awaits the flow without delay,
And nudges extra borrows out of the way.
The code sits neat beneath the moon,
While whiskers hum a tidy tune.
Comment @coderabbitai help to get the list of available commands.
12 tasks done
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Tiny Sweeper reviewTiny Sweeper completed its review; deterministic results follow. State: Incomplete Review snapshot
Completeness: Incomplete Features
TestsNo supported feature-to-test mapping was produced. Test execution is not inferred.
FindingsNo active actionable findings. Could not review: crates/openhuman-embed/tests/flow_approvals.rs, tinysweeper/tests Before merge
How this fits togetherflowchart LR
n0["dispatch_triage<br/>changed"]:::changed
n1["Result"]:::impacted
n2["load_config"]:::impacted
n3["setup_wallet_in"]:::impacted
n4["run"]:::impacted
n5["setup"]:::impacted
n6["lookup_tx"]:::impacted
n0 -->|uses| n1
n2 -->|uses| n1
n3 -->|uses| n1
n3 -->|calls| n2
n3 -->|tests| n2
n3 -->|calls| n5
n3 -->|tests| n5
n4 -->|uses| n1
n4 -->|calls| n6
n5 -->|uses| n1
n5 -->|calls| n2
n6 -->|uses| n1
n6 -->|calls| n2
classDef changed fill:#0d4429,stroke:#238636,color:#e6edf3
classDef impacted fill:#161b22,stroke:#6e7681,color:#c9d1d9
classDef flagged fill:#5a1e02,stroke:#d93f0b,color:#ffffff
classDef blocking fill:#67060c,stroke:#f85149,color:#ffffff
Agent review detailscritique
security
tests
commits
description
Evidence and run details
|
![tinysweeper[bot]](https://avatars.githubusercontent.com/in/4526585?s=60&v=4){kind=small}
There was a problem hiding this comment.
tinysweeper found nothing blocking, but could not review everything, so this is not an approval: crates/openhuman-embed/tests/flow_approvals.rs, tinysweeper/tests.
$0.0021 · 146,870 in / 4,619 out · 0 cached (0%) · ladder/vectors-oai3, glm-5.3-flash · 289 embedded
critique: $0.0006 · 63,791 in / 1,419 out · 0 cached (0%) · glm-5.3-flash
security: $0.0005 · 45,171 in / 630 out · 0 cached (0%) · glm-5.3-flash
tests: $0.0001 · 14,546 in / 16 out · 0 cached (0%) · glm-5.3-flash
description: $0.0003 · 19,584 in / 1,065 out · 0 cached (0%) · glm-5.3-flash
tinysweeper
Bot
added
the
priority: p3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
clippy-product,embed-clippyandtinyhumans-clippylanes (-D warnings) on main:use crate::config::rpc as config_rpc;imports;needless_borrows:&ctxwherectxis already a&DispatchCtx;redundant_async_blockinopenhuman-embed/tests/flow_approvals.rs.Problem
The CI Fast (EX63) run on #7876 (run 38862114600, tested against main e480f86) failed all three clippy lanes on 121 diagnostics in
openhuman-core: 77unused importand 44needless_borrow. The embed and tinyhumans lanes fail on the sameopenhuman-corelib errors.#7842 (9a25e9d) already removed most of them. On main at 9a25e9d, 15 remain:
config_rpcimported but unused invoice/live/schemas.rs,voice/schemas/handlers/{provider_server,transcribe_tts}.rs,web3/{bridge,dapp,swap}/schemas.rsandweb3/wallet/{execution,ops}.rs;&ctxon actx: &DispatchCtxinintegrations/task_sources/route.rs(dispatch_triage, 2 sites) andweb3/wallet/tools.rs(WalletModuleTool::run, 5 sites).Solution
web3/wallet/test_support.rs(#[cfg(all(test, feature = "web3"))]), which the test builds warn on.flow_approvals.rs, collapseasync move { async move { … }.await }into the inner block.ctxinstead of&ctxat the 7 sites; every callee (run_triage,apply_decision,wallet::{status, chain_status, tx_status, tx_receipt, lookup_tx}) takes&DispatchCtx.web3/wallet/tools.rs:72keeps&ctx, because thatctxis an owned value;shell::{scan, classify, env_guard}deprecation warnings insecurity/policy/command_checks.rs(warnings in test builds, not lint errors);voice/dictation_listener.rs:109(ctxunused): this fires only on macOS, where thectxuse is behind#[cfg(not(target_os = "macos"))]. CI clippy runs on Linux, so it isn't a lane failure;pub use … as config_rpcre-export inmcp/server/tools/mod.rs(a re-export, not flagged).Submission Checklist
Impact
Related
AI Authored PR Metadata (required for Codex/Linear PRs)
Linear Issue
Commit & Branch
Validation Run
pnpm --filter openhuman-app format:check: no frontend files changed.pnpm typecheck: no frontend files changed.rustfmt --checkon the changed files; lane clippy commands run once each on macOS:openhuman-tinyhumans --all-targetspasses (0 errors);-p openhuman(core product features) has 0 errors except the macOS-onlydictation_listenerone above;openhuman-embed --all-targetsreported only theflow_approvals.rsredundant_async_block, fixed here. That target stopped the run, so this PR's CI is the confirmation for the remaining embed targets.Validation Blocked
command:N/Aerror:N/Aimpact:N/ABehavior Changes
Parity Contract
Duplicate / Superseded PR Handling
Summary by CodeRabbit